Skip C-API in workspace coverage by moreal · Pull Request #8619 · RustPython/RustPython · GitHub
Skip to content

Skip C-API in workspace coverage - #8619

Open
moreal wants to merge 1 commit into
RustPython:mainfrom
moreal:ci/exclude-capi-from-coverage
Open

Skip C-API in workspace coverage#8619
moreal wants to merge 1 commit into
RustPython:mainfrom
moreal:ci/exclude-capi-from-coverage

Conversation

@moreal

@moreal moreal commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

The periodic coverage job runs tests from the workspace root, which causes the rustpython-capi test binary to be built without the crate-local PyO3 configuration from crates/capi/.cargo/config.toml. The binary consequently crashes with SIGSEGV as soon as its unit tests start. This failure appeared in the run associated with #8616, but the same failure has also affected scheduled runs on main since C-API tests were enabled.

This change excludes rustpython-capi from the root workspace coverage invocation, matching the existing regular CI workflow. The C-API suite remains covered by its dedicated CI invocation from crates/capi, where all 102 tests pass with the required configuration. I also verified the remaining workspace tests, clippy, formatting, pre-commit hooks, actionlint, and the workflow security scan locally.

Summary by CodeRabbit

  • Chores
    • Updated Rust test coverage reporting to exclude an additional internal package.
    • No user-facing functionality or behavior changes.

@coderabbitai

coderabbitai Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added the z-ca-2026 Tag to track Contribution Academy 2026 label Aug 30, 2026
@moreal moreal added the skip:ci Skip running the ci label Aug 30, 2026
@moreal moreal changed the title CI: exclude C-API tests from workspace coverage CI: skip C-API in workspace coverage Aug 30, 2026
@moreal moreal changed the title CI: skip C-API in workspace coverage Skip C-API in workspace coverage Aug 30, 2026
@moreal
moreal marked this pull request as ready for review August 30, 2026 07:33
Assisted-by: Codex:gpt-5.6-sol
@moreal
moreal force-pushed the ci/exclude-capi-from-coverage branch from 0a11833 to f2df899 Compare August 30, 2026 07:34
@moreal
moreal marked this pull request as draft August 30, 2026 07:35
@moreal
moreal marked this pull request as ready for review August 30, 2026 07:35
@moreal
moreal requested a review from youknowone August 30, 2026 08:08

@bschoenmaeckers bschoenmaeckers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip:ci Skip running the ci z-ca-2026 Tag to track Contribution Academy 2026

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants