{{ message }}
Drop the lint expectations clippy 1.98 no longer fulfils - #8564
Merged
youknowone merged 1 commit intoAug 21, 2026
Merged
Conversation
`clippy::std_instead_of_core` stopped firing at the four places that carry an `#[expect]` for it. All four were added for the same false positive, on items whose `core` counterpart is still unstable. `unfulfilled_lint_expectations` is denied through `-D warnings`, so the three clippy jobs and the WASM check fail on current stable for every pull request, whatever it touches. Assisted-by: Claude Code:claude-opus-5
Contributor
This was referenced Aug 21, 2026
Member
youknowone
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
The three clippy jobs and the WASM check fail on current stable for any pull request, whatever it touches:
clippy::std_instead_of_coreno longer fires at four of the places that carry an#[expect]for it, all four written for the same false positive on items whosecorecounterpart is still unstable. Once the lint stops firing,unfulfilled_lint_expectationsturns each of those attributes into an error under-D warnings, and the crate fails to check.Removing the four is enough. The other two
#[expect(clippy::std_instead_of_core)]in the tree, incrates/host_env/src/posix.rsandcrates/vm/src/stdlib/_signal.rs, still fire, so they stay.Test Plan
rustc 1.98.0 (88d9e12ae 2026-08-18) in a Debian container.
The command CI runs, with the same flags:
finishes clean here. Without the change it stops at
crates/host_env/src/fileutils.rs:449, then atcrates/vm/src/stdlib/_io.rs:117, then atcrates/stdlib/src/pyexpat.rs:4andcrates/stdlib/src/ssl.rs:17. The same four jobs are red on #8561, #8562 and #8563 for the first of those.Also run:
cargo fmt --check, clean, andcargo test --workspace --exclude rustpython_wasm --exclude rustpython-venvlauncher --exclude rustpython-capi, 41 test binaries and no failures.Summary by CodeRabbit