{{ message }}
Fix zero padding for string format specs - #8407
Merged
youknowone merged 2 commits intoJul 29, 2026
Merged
Conversation
Assisted-by: Codex:gpt-5
Assisted-by: Codex:gpt-5
Contributor
Contributor
youknowone
approved these changes
Jul 29, 2026
youknowone
left a comment
Member
There was a problem hiding this comment.
looks good, thank you for catching this
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Resolves the
{0:08s}portion of the existingTODO: RUSTPYTHONintest_str.test_format.0flag in string format specs as zero fill with string alignment semantics.=alignment for strings with CPython'sValueErrormessage.{0.}expected-failure reason in place.Tests
prek run --all-filescargo clippycargo test --workspace --exclude rustpython_wasm --exclude rustpython-venvlaunchercargo run --release -- -m test test_strpytest -vinextra_testsusing the RustPython binaryAI assistance
Codex (GPT-5) assisted with the CPython comparison, implementation, and regression-test drafting. I reviewed the final diff and verified the behavior locally. Both commits include
Assisted-by: Codex:gpt-5.