crates/stdlib/src/csv.rs (1)

799-839: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Consolidate duplicated dialect-resolution logic across the three branches.

Each branch (Str, Obj, default "excel") repeats the identical .delimiter(...).double_quote(...).escape(...) chain plus the quotechar check, differing only in which PyDialect is used. Since this PR is adding a third repeated line (.escape(...)) to all three branches, it's a good point to extract the differing value once.

♻️ Proposed refactor

 fn to_reader(&self) -> csv_core::Reader {
-    let mut builder = csv_core::ReaderBuilder::new();
-    let mut reader = match &self.dialect {
-        DialectItem::Str(name) => {
-            let g = GLOBAL_HASHMAP.lock();
-            if let Some(dialect) = g.get(name) {
-                let mut builder = builder
-                    .delimiter(dialect.delimiter)
-                    .double_quote(dialect.doublequote)
-                    .escape(dialect.escapechar);
-                if let Some(t) = dialect.quotechar {
-                    builder = builder.quote(t);
-                }
-                builder
-            } else {
-                &mut builder
-            }
-        }
-        DialectItem::Obj(obj) => {
-            let mut builder = builder
-                .delimiter(obj.delimiter)
-                .double_quote(obj.doublequote)
-                .escape(obj.escapechar);
-            if let Some(t) = obj.quotechar {
-                builder = builder.quote(t);
-            }
-            builder
-        }
-        _ => {
-            let name = "excel";
-            let g = GLOBAL_HASHMAP.lock();
-            let dialect = g.get(name).unwrap();
-            let mut builder = builder
-                .delimiter(dialect.delimiter)
-                .double_quote(dialect.doublequote)
-                .escape(dialect.escapechar);
-            if let Some(quotechar) = dialect.quotechar {
-                builder = builder.quote(quotechar);
-            }
-            builder
-        }
-    };
+    let resolved = match &self.dialect {
+        DialectItem::Str(name) => GLOBAL_HASHMAP.lock().get(name).copied(),
+        DialectItem::Obj(obj) => Some(*obj),
+        _ => GLOBAL_HASHMAP.lock().get("excel").copied(),
+    };
+
+    let mut builder = csv_core::ReaderBuilder::new();
+    let mut reader = if let Some(dialect) = resolved {
+        let mut b = builder
+            .delimiter(dialect.delimiter)
+            .double_quote(dialect.doublequote)
+            .escape(dialect.escapechar);
+        if let Some(t) = dialect.quotechar {
+            b = b.quote(t);
+        }
+        b
+    } else {
+        &mut builder
+    };

As per coding guidelines, "When branches differ only in a value but share common logic, extract the differing value first, then call the common logic once to avoid duplicate code."

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/stdlib/src/csv.rs` around lines 799 - 839, Refactor to_reader so the
DialectItem::Str, DialectItem::Obj, and default "excel" branches first resolve a
single PyDialect reference, then apply delimiter, double_quote, escape, and
optional quotechar configuration once. Preserve the existing named-dialect
lookup and fallback behavior while eliminating the duplicated ReaderBuilder
configuration chains.

Source: Coding guidelines

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes