Pin deps to their minor version by ShaharNaveh · Pull Request #7473 · RustPython/RustPython · GitHub
Skip to content

Pin deps to their minor version#7473

Open
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:pin-lexopt
Open

Pin deps to their minor version#7473
ShaharNaveh wants to merge 1 commit intoRustPython:mainfrom
ShaharNaveh:pin-lexopt

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Mar 20, 2026

When deps don't specify their minor version dependabot only update Cargo.lock (see #7470 for example).

This PR ensures that dependabot updates Cargo.toml as well.

Closes #7470

Summary by CodeRabbit

  • Chores
    • Updated project dependencies to latest stable versions for improved compatibility and performance.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 20, 2026

moreal
moreal previously approved these changes Mar 20, 2026
@youknowone
Copy link
Copy Markdown
Member

RustPython is a binary and a library. Library user uses Cargo.toml and application uses uses Cargo.lock. Specifying the latest version is good for application users, but not for library users

@ShaharNaveh
Copy link
Copy Markdown
Contributor Author

RustPython is a binary and a library. Library user uses Cargo.toml and application uses uses Cargo.lock. Specifying the latest version is good for application users, but not for library users

That's a good point.
I believe consistency is good, which way should we choose?

@moreal moreal requested review from moreal and removed request for moreal March 22, 2026 11:03
@moreal
Copy link
Copy Markdown
Contributor

moreal commented Mar 22, 2026

When I originally gave the approval, I hadn't considered the library users. Thinking back on it, it's actually normal behavior for Dependabot to only update Cargo.lock in that regard. For the sake of library users, we need to use the most generous (lowest) version possible, as long as it doesn't affect functionality.

So, honestly, I'm leaning toward sticking with the current approach. In the case of something like bstr = "1", it originally allowed versions like 1.0.x to be used, but now it requires 1.12.1 or higher.

@moreal moreal dismissed their stale review March 22, 2026 11:08

I didn't think in RustPython-as-library side when I approved.

@youknowone
Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants