{{ message }}
Add CI step for checking redundant test patches - #7126
Merged
Conversation
Contributor
This was referenced Feb 14, 2026
Member
|
@ShaharNaveh Can this be auto-fix using update_lib instead just lint? |
Contributor
Author
Yes, but I'd rather not doing that, for multiple reasons:
|
ShaharNaveh
marked this pull request as ready for review
February 14, 2026 14:26
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/ci.yaml:
- Around line 462-470: Remove the duplicate checkout step: the workflow contains
two identical steps using "uses: actions/checkout@v6.0.2"; keep the first
checkout that precedes the "Check for redundant test patches" step and delete
the second "uses: actions/checkout@v6.0.2" entry to avoid re-checking out the
repo unnecessarily.
In `@scripts/check_redundant_patches.py`:
- Around line 18-23: The except SyntaxError block after calling
ast.parse(contents) currently uses pass, which lets execution continue to
ast.walk(tree) and causes NameError or stale-tree reuse; change the handler so
the file is skipped (e.g., continue out of the loop) or explicitly set tree =
None and skip calling ast.walk for that file — update the block around
ast.parse(contents) / ast.walk(tree) to ensure that when ast.parse raises
SyntaxError you do not call ast.walk on an undefined or previous tree.
🧹 Nitpick comments (2)
scripts/check_redundant_patches.py (2)
12-12:rglob("**/*.py")double-recurses; userglob("*.py")instead.
Path.rglobalready applies the pattern recursively, so the leading**/is redundant. It still works, butrglob("*.py")is the idiomatic form.Proposed fix
- for file in TEST_DIR.rglob("**/*.py"): + for file in TEST_DIR.rglob("*.py"):
51-52: Prefersys.exit()over the builtinexit().
sysis already imported. The builtinexit()is intended for the interactive interpreter;sys.exit()is the standard way to exit from scripts.Proposed fix
if __name__ == "__main__": - exit(main()) + sys.exit(main())
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using:
git pull origin lint-script-patches |
Member
|
@ShaharNaveh could you check coderabbitai reviews? |
Member
ShaharNaveh
force-pushed
the
lint-script-patches
branch
from
February 15, 2026 08:56
800bf35 to
0da173a
Compare
youknowone
approved these changes
Feb 15, 2026
youknowone
pushed a commit
to youknowone/RustPython
that referenced
this pull request
Mar 22, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores