{{ message }}
Remove Copy from PyPayload#6865
Merged
youknowone merged 2 commits intoRustPython:mainfrom Jan 24, 2026
Merged
Conversation
This reverts commit 2f76ef6.
Contributor
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
crates/vm/src/builtins/module.rs (1)
44-71: Guard against custom create slots returning incomplete modules.
create_modulealways calls__init_dict_from_def, which unwrapsmodule.defandmodule.name. If a custom create slot returns a module without those fields initialized, this will panic. Add an explicit guard (or normalize the module) before continuing.🛡️ Suggested guard
@@ - // Initialize module dict and methods - PyModule::__init_dict_from_def(vm, &module); + // Initialize module dict and methods + if module.def.is_none() || module.name.is_none() { + return Err(vm.new_system_error(format!( + "module '{}' was created without a complete PyModuleDef", + self.name.as_str() + ))); + } + PyModule::__init_dict_from_def(vm, &module); module.__init_methods(vm)?;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyPayloads are expected to be exposed via PyRef. Copy/Clone for them doesn't make sense for most of cases. If they are used, that must be careful to take risk to confuse it to PyRef clone
Summary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.