Walkthrough

The changes refactor PyFunctionNewArgs struct field signatures, converting OptionalArg types to Option, renaming defaults to argdefs, and enhance builtins resolution logic to fallback to vm.builtins.dict() with module unwrapping. The py_new constructor is updated to validate closure length against code.freevars. A test is added to verify that function \builtins resolves to a dict.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

• Pyfunction builtins and constructor #5823: Modifies PyFunction construction and builtins handling in the same core file with overlapping focus areas.
• SetFunctionAttribute #5968: Changes PyFunction constructor behavior, closure validation, and defaults/kwdefaults field handling in parallel updates.

Poem

🐰 Hoppy defaults find their way,
From OptionalArg to Option's ray,
Closure validation stands so tall,
Builtins unwrapped—dict for all!

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

• X
• Mastodon
• Reddit
• LinkedIn