{{ message }}
Updated the urllib + http libraries + test libraries - #6672
Merged
Merged
Conversation
Contributor
terryluan12
changed the title
terryluan12
force-pushed
the
update_urllib_http
branch
from
January 7, 2026 02:19
3569649 to
b35d242
Compare
terryluan12
changed the title
terryluan12
marked this pull request as draft
January 7, 2026 02:22
youknowone
reviewed
Jan 7, 2026
Comment on lines
+1760
to
+1761
| # TODO: RUSTPYTHON; Currently, __new__ is not treated specially in __dict__ | ||
| # new_member = __new__.__func__ |
Member
There was a problem hiding this comment.
what happens without this patch?
Contributor
Author
There was a problem hiding this comment.
Whoops! That error was why I added #6658. Now that it's resolved, it should be good to uncomment. I'll give it a shot after I finish testing asyncio
terryluan12
force-pushed
the
update_urllib_http
branch
2 times, most recently
from
January 7, 2026 05:59
aa54aa7 to
86edf1d
Compare
ShaharNaveh
reviewed
Jan 7, 2026
Contributor
There was a problem hiding this comment.
I think changes of this file can be in their own PR
terryluan12
force-pushed
the
update_urllib_http
branch
2 times, most recently
from
January 10, 2026 07:29
ac5387b to
b44d087
Compare
terryluan12
changed the title
Contributor
|
Code has been automatically formatted The code in this PR has been formatted using git pull origin update_urllib_http |
terryluan12
force-pushed
the
update_urllib_http
branch
from
January 10, 2026 17:04
bffcbf9 to
9119a2f
Compare
fanninpm
reviewed
Jan 11, 2026
fanninpm
left a comment
fanninpm
left a comment
Contributor
There was a problem hiding this comment.
In addition to these in-line comments, I was wondering if the tests currently marked with this:
@unittest.skipIf(os.name == 'nt', 'TODO: RUSTPYTHON; ValueError: illegal environment variable name')…could be replaced with this:
@unittest.expectedFailureIfWindows('TODO: RUSTPYTHON; ValueError: illegal environment variable name')
terryluan12
force-pushed
the
update_urllib_http
branch
3 times, most recently
from
January 16, 2026 01:57
f36bb4c to
d1c7bc3
Compare
terryluan12
force-pushed
the
update_urllib_http
branch
from
January 16, 2026 04:10
b1c8a36 to
2d63721
Compare
terryluan12
marked this pull request as ready for review
January 16, 2026 04:48
youknowone
approved these changes
Jan 16, 2026
Member
There was a problem hiding this comment.
this is interesting that this update fixes a lot of other tests but broken this one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.