Move `derive` -> `crates/derive` by ShaharNaveh · Pull Request #6264 · RustPython/RustPython · GitHub
Skip to content

Move derive -> crates/derive#6264

Merged
youknowone merged 8 commits intoRustPython:mainfrom
ShaharNaveh:move-derive
Nov 15, 2025
Merged

Move derive -> crates/derive#6264
youknowone merged 8 commits intoRustPython:mainfrom
ShaharNaveh:move-derive

Conversation

@ShaharNaveh
Copy link
Copy Markdown
Contributor

@ShaharNaveh ShaharNaveh commented Nov 14, 2025

ref: #6214

Summary by CodeRabbit

  • Chores
    • Reorganized internal package layout and adjusted internal dependency references to reflect the new layout.
    • Removed an internal workspace member that is no longer part of the build configuration.
    • No user-facing changes or functionality impacts.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 14, 2025

@fanninpm
Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and dc7df08.

📒 Files selected for processing (2)
  • Cargo.toml (1 hunks)
  • jit/Cargo.toml (1 hunks)
🔇 Additional comments (1)
Cargo.toml (1)

154-154: Migration verified—no issues remain.

The crate relocation is complete and correct:

  • crates/derive/Cargo.toml exists with valid structure
  • ✓ No stale path = "derive" references found
  • ✓ All consumers (jit, pylib, stdlib, vm) use workspace = true
  • ✓ Root Cargo.toml line 154 correctly references path = "crates/derive"
  • ✓ Workspace glob pattern crates/* captures the moved crate
  • derive-impl (separate crate at root level) correctly remains an explicit member

Comment thread jit/Cargo.toml Outdated
@youknowone youknowone merged commit 8715ae7 into RustPython:main Nov 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants