Fix stable clippy by youknowone · Pull Request #5843 · RustPython/RustPython · GitHub
Skip to content

Fix stable clippy - #5843

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:fix-clippy
Jun 27, 2025
Merged

Fix stable clippy#5843
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:fix-clippy

Conversation

@youknowone

@youknowone youknowone commented Jun 27, 2025

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Style
    • Updated string formatting throughout the application to use modern named parameter syntax, improving code readability and consistency. No changes to functionality or output.
  • Chores
    • Refined error and panic message formatting for clarity without altering behavior.
    • Added a dependency override for the radium crate to source from a specific Git repository and branch.

@coderabbitai

coderabbitai Bot commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d492a6 and 13e33b6.

📒 Files selected for processing (7)
  • stdlib/src/array.rs (1 hunks)
  • vm/src/builtins/genericalias.rs (1 hunks)
  • vm/src/frame.rs (4 hunks)
  • vm/src/stdlib/functools.rs (2 hunks)
  • vm/src/stdlib/sys.rs (1 hunks)
  • vm/src/stdlib/typing.rs (4 hunks)
  • vm/src/vm/vm_object.rs (2 hunks)
🧰 Additional context used
🧠 Learnings (4)
📓 Common learnings
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Always use 'cargo fmt' to format Rust code and follow the default rustfmt code style when contributing to RustPython.
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Minimize modifications to CPython standard library files in the Lib/ directory; bug fixes should be made through Rust code modifications whenever possible.
vm/src/vm/vm_object.rs (3)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Minimize modifications to CPython standard library files in the Lib/ directory; bug fixes should be made through Rust code modifications whenever possible.
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Follow Rust best practices for error handling and memory management in all RustPython Rust code.
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Always use 'cargo fmt' to format Rust code and follow the default rustfmt code style when contributing to RustPython.
vm/src/stdlib/sys.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Follow Rust best practices for error handling and memory management in all RustPython Rust code.
vm/src/stdlib/typing.rs (1)
Learnt from: CR
PR: RustPython/RustPython#0
File: .github/copilot-instructions.md:0-0
Timestamp: 2025-06-26T12:52:11.109Z
Learning: Always use 'cargo fmt' to format Rust code and follow the default rustfmt code style when contributing to RustPython.
⏰ Context from checks skipped due to timeout of 90000ms (11)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run tests under miri
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
🔇 Additional comments (10)
vm/src/builtins/genericalias.rs (1)

391-393: LGTM: Modernized string formatting syntax.

The inline formatting {idx} is more concise and readable than the previous multi-line approach. This follows modern Rust idioms and addresses clippy suggestions.

stdlib/src/array.rs (1)

604-604: LGTM: Improved type casting with inference.

Using as _ allows the compiler to infer the target type from the function signature, making the code more concise while maintaining the same functionality. This addresses clippy's suggestion for unnecessary explicit type annotation.

vm/src/stdlib/typing.rs (3)

174-178: LGTM: Modernized TypeVar representation formatting.

The inline variable formatting ({name}) is more readable and concise than the previous positional argument style. This follows modern Rust formatting conventions while maintaining identical functionality.


741-741: LGTM: Improved TypeVarTuple formatting.

Using inline variable formatting improves readability and follows modern Rust idioms.


788-788: LGTM: Consistent ParamSpec formatting improvements.

Both ParamSpecArgs and ParamSpecKwargs now use the modern inline variable formatting syntax, making the code more consistent and readable across the typing module.

Also applies to: 867-867

vm/src/vm/vm_object.rs (1)

23-23: LGTM! String formatting modernized correctly.

The panic messages have been appropriately updated to use inline variable interpolation syntax instead of positional formatting. This improves readability and addresses clippy warnings while maintaining identical functionality.

Also applies to: 41-41, 52-52

vm/src/stdlib/sys.rs (1)

375-379: LGTM! Exception error formatting modernized.

The error message formatting has been correctly updated to use named parameter syntax. The {type_name} placeholder and {msg} interpolation improve code clarity while maintaining the same error output behavior.

vm/src/stdlib/functools.rs (1)

289-292: LGTM! Repr formatting modernized with named parameters.

The repr_str method's string formatting has been appropriately updated to use named parameter syntax throughout. This improves code readability in the complex repr construction logic while maintaining identical output formatting.

Also applies to: 312-312, 319-322

vm/src/frame.rs (2)

352-355: OK – purely stylistic change

The switch to named-argument formatting is correct and keeps behaviour intact.


1650-1651: Looks good – safer & clearer mapping validation

Using the named-argument style keeps the message intact and improves readability.

Comment thread vm/src/frame.rs Outdated
Comment thread vm/src/frame.rs Outdated
@youknowone
youknowone force-pushed the fix-clippy branch 2 times, most recently from 0cfb19f to 5a2da9f Compare June 27, 2025 03:02
@youknowone
youknowone merged commit fe2c9bf into RustPython:main Jun 27, 2025
@youknowone
youknowone deleted the fix-clippy branch June 27, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant