{{ message }}
derive __text_signature__ from method definition - #2923
Merged
Conversation
youknowone
changed the title
youknowone
force-pushed
the
derive-text-signature
branch
from
August 21, 2021 16:14
7d9bb27 to
374f263
Compare
DimitrisJim
reviewed
Aug 22, 2021
Member
youknowone
force-pushed
the
derive-text-signature
branch
2 times, most recently
from
August 22, 2021 04:38
be8790a to
65dd911
Compare
Member
Author
|
Yes, that will be a new concern for argument names. Already generated |
youknowone
force-pushed
the
derive-text-signature
branch
from
August 22, 2021 08:11
65dd911 to
5ee9719
Compare
moreal
reviewed
Aug 22, 2021
Comment on lines
-17
to
-19
Contributor
There was a problem hiding this comment.
As I understood, ImplItem<Item> for MethodItem will not affect at class documentation ClassItem. When I executed object.__text_signature__, it returns None. I guess these changes will revert some resolved problems again (#2732 (comment), #2623 (comment)).
youknowone
force-pushed
the
derive-text-signature
branch
from
August 22, 2021 08:37
5ee9719 to
da16618
Compare
moreal
approved these changes
Aug 22, 2021
DimitrisJim
approved these changes
Aug 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is not perfectly solving the issue but showing the first step to go. I think we can keep the signature and actual function better from this way.
improving #2904 in automated way
cc @moreal