Fix index and overflow error in itertools by clemado1 · Pull Request #2116 · RustPython/RustPython · GitHub
Skip to content

Fix index and overflow error in itertools - #2116

Merged
youknowone merged 1 commit into
RustPython:masterfrom
clemado1:itertools
Aug 15, 2020
Merged

Fix index and overflow error in itertools#2116
youknowone merged 1 commit into
RustPython:masterfrom
clemado1:itertools

Conversation

@clemado1

@clemado1 clemado1 commented Aug 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor
  1. fix index error (refer to CPython)
test_permutations (__main__.TestBasicOps) ... thread 'main' panicked at 'index out of bounds: the len is 4 but the index is 4', vm/src/stdlib/itertools.rs:1420:42
  1. fix overflow error in debug mode when r > n

coolreader18
coolreader18 approved these changes Aug 15, 2020
View reviewed changes

@coolreader18 coolreader18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work :)

@coolreader18

coolreader18 commented Aug 15, 2020

Copy link
Copy Markdown
Member

@youknowone
youknowone merged commit fef9bbb into RustPython:master Aug 15, 2020
@youknowone

youknowone commented Aug 15, 2020

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coolreader18 coolreader18 coolreader18 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@clemado1 @coolreader18 @youknowone