{{ message }}
This repository was archived by the owner on May 15, 2026. It is now read-only.
fix: avoid deleting configs if the currentApiConfigName is the same#481
Merged
Merged
Conversation
monotykamary
requested review from
ColemanRoo,
mrubens and
stea9499
as code owners
monotykamary
changed the title
mrubens
approved these changes
Jan 22, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where configs were being deleted even when the config name was not changed. This change ensures that configs are only deleted when their names are actually modified.
Type of change
How Has This Been Tested?
Manually tested by building the extension and editing the config without making any changes to the config name. Verified that configs are not deleted in this scenario.
Checklist:
Additional context
This fix addresses a bug introduced in a previous change that incorrectly deleted configs even when no changes were made to their names.
Related Issues
Reviewers
Important
Fixes bug in
ApiConfigManager.tsxto prevent config deletion whencurrentApiConfigNameis unchanged.ApiConfigManager.tsxwhere configs were deleted even ifcurrentApiConfigNamewas unchanged.onRenameConfigis now only called ifcurrentApiConfigNamediffers fromtrimmedValue.This description was created by
for 8ad904a. It will automatically update as commits are pushed.