{{ message }}
ENH: Implement Parachute Opening Shock Force Estimation#910
Open
FelipeAlmeidaUSP wants to merge 2 commits intoRocketPy-Team:developfrom
Open
ENH: Implement Parachute Opening Shock Force Estimation#910FelipeAlmeidaUSP wants to merge 2 commits intoRocketPy-Team:developfrom
FelipeAlmeidaUSP wants to merge 2 commits intoRocketPy-Team:developfrom
Conversation
Author
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #910 +/- ##
===========================================
+ Coverage 80.27% 81.04% +0.77%
===========================================
Files 104 107 +3
Lines 12769 13659 +890
===========================================
+ Hits 10250 11070 +820
- Misses 2519 2589 +70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gui-FernandesBR
force-pushed
the
enh/parachute-shock-force
branch
from
809f8eb to
0f8f3a6
Compare
Member
|
@FelipeAlmeidaUSP please fix git conflicts before our review.
Also, please fix linters |
4 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey team!
I am submitting this PR as part of my participation on the recruitment process for the RocketPy Library Development Team.
I decided on taking on the following issue: #161
Here, I updated the parachute class to include the "calculate_opening_shock" function to estimate the opening shock force during the rocket's parachute opening. I followed the discussion topics on the github issue and consulted the reference textbook in order to implement my proposed feature.
I created a new test file under the unit test folder to evaluate if my formula was correctly estimating the force related to the parachute opening process, where I implemented the following example from the textbook and compared if the results presented in the code and in the book matched. The test was successful.
I also integrated the calculation function into the flight simulations to account for the conditions during the exact moment the parachute is triggered. However, while I was adding a new test to the flight simulations, under the integration folder, to confirm if the integration was being done correctly I was unable to get the test to function properly and the errors resulted in the test's fail.
I spent a few hours debugging but was unable to find the problem, but I included in these files a few # TODO comments highlighting the next steps to complete the proposed feature, including both roadmap changes to improve on the analysis and the fix related to the integration test. I am open to suggestions and corrections in my additions, please feel free to reach out to me!
Thanks for the opportunity to learn new things while helping the tool expand!