Repository navigation
chore(fuselage): skip breakpoints without minimum width in Storybook viewports - #42996
MYMISERABLEMIND17 wants to merge 1 commit into
Conversation
…viewports The xs breakpoint token defines minViewportWidth as null, causing Storybook to construct an invalid width: 'nullpx' viewport. Skipping breakpoints without a minimum width prevents invalid viewport styles and keeps Storybook viewport presets clean. Closes RocketChat#42791
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughThe Storybook viewport configuration now excludes breakpoints with a null ChangesStorybook viewport configuration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix · Severity of issue fixed: Low Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: skipping breakpoints without a minimum width in Storybook viewport generation. |
| Linked Issues check | |
Issue #42791 requires preventing an invalid nullpx Storybook viewport for the xs breakpoint. In packages/fuselage/.storybook/preview.tsx, the viewport generation now filters entries with `minVie… |
| Out of Scope Changes check | |
The reviewed change is limited to the Storybook viewport generation in packages/fuselage/.storybook/preview.tsx. The filter and the related mapping reformat directly support issue #42791. No unrelat… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… |
Full details: Linked Issues check
-
Explanation
Issue
#42791requires preventing an invalidnullpxStorybook viewport for thexsbreakpoint. Inpackages/fuselage/.storybook/preview.tsx, the viewport generation now filters entries withminViewportWidth != nullbefore mapping them to viewport definitions. This preserves valid breakpoint widths and excludesxs. The issue does not require a specific automated test.
Full details: Out of Scope Changes check
-
Explanation
The reviewed change is limited to the Storybook viewport generation in
packages/fuselage/.storybook/preview.tsx. The filter and the related mapping reformat directly support issue#42791. No unrelated change is shown.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This branch has not been deployed
2 participants
Closes #42791
Proposed changes
The
xsbreakpoint token in@rocket.chat/fuselagedefinesminViewportWidthasnull, causing Storybook's viewport addon in.storybook/preview.tsxto construct an invalidnullpxwidth.Filtering out breakpoint entries where
minViewportWidth == nullensures only valid, functional viewport presets (smand above) are exposed in the Storybook toolbar, preventing the preview iframe from collapsing or rendering invalid styles.Verification
packages/fuselage/.storybook/preview.tsx.breakpointTokenswithoutminViewportWidthare excluded whilesm,md,lg,xlretain their respective pixel bounds.Summary by CodeRabbit