Repository navigation
fix: 'No History' state displayed incorrectly when calendar-events.list fails - #42971
nazabucciarelli wants to merge 198 commits into
Conversation
Co-authored-by: dougfabris <devfabris@gmail.com>
…t for local creation
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📜 Recent review details
WalkthroughThe Outlook calendar empty state now renders only after a successful query returns zero events. Tests cover failed and empty calendar-event responses. ChangesOutlook calendar empty state
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Change: Bug fix Suggested labels: Suggested reviewers: Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly describes the main change: preventing the 'No History' state from appearing when calendar-events.list fails. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Errors were encountered while retrieving linked issues.
Errors: 1
-
- JIRA integration encountered authorization issues. Please disconnect and reconnect the integration in the CodeRabbit UI.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/outlook-server-to-server-integration-phase-3 #42971 +/- ##
=====================================================================================
- Coverage 71.35% 71.31% -0.04%
=====================================================================================
Files 5461 5467 +6
Lines 235750 236131 +381
Branches 42701 42636 -65
=====================================================================================
+ Hits 168217 168395 +178
- Misses 62232 62438 +206
+ Partials 5301 5298 -3 Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
8d2664c to
ebb0437
Compare
ebb0437 to
bb801ea
Compare
This branch has not been deployed
2 participants
Proposed changes (including videos or screenshots)
Modified the condition to display the 'No history' state. It must show up when the request was successful and there were no events.
Issue(s)
OS2S-74 Outlook calendar panel shows “Something went wrong” and “No history” states at the same time when offline.
Steps to test or reproduce
rocketchat_calendar_eventscollection for your user.calendar-events.list.Expected: It should display 'Something went wrong' instead of 'Something went wrong' with 'No history'.
Further comments
Summary by CodeRabbit