Make Homebrew Cask into an attribute to allow for using adoptopenjdk by Brantone · Pull Request #3 · Roblox/java · GitHub
Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Make Homebrew Cask into an attribute to allow for using adoptopenjdk#3

Merged
Brantone merged 2 commits into
Roblox:masterfrom
Brantone:master
May 6, 2019
Merged

Make Homebrew Cask into an attribute to allow for using adoptopenjdk#3
Brantone merged 2 commits into
Roblox:masterfrom
Brantone:master

Conversation

@Brantone

@Brantone Brantone commented May 2, 2019

Copy link
Copy Markdown

No description provided.

@Brantone Brantone requested a review from zirkov May 2, 2019 17:04
@Brantone

Brantone commented May 2, 2019

Copy link
Copy Markdown
Author

@zirkov

zirkov commented May 2, 2019

Copy link
Copy Markdown

LGTM!
By the way, Linux build nodes (docker based ones) are using AdoptOpenJdk container as their base (https://github.com/JetBrains/teamcity-docker-minimal-agent/blob/95ae4e7c836ce3199be126edb286f6b1f0e9e15e/ubuntu/Dockerfile#L1), so might make sense to force our Mac nodes to use it by default

@Brantone

Brantone commented May 2, 2019

Copy link
Copy Markdown
Author

Yeah, subsequent downstream cookbooks will also make use of that.

@Brantone Brantone merged commit 3ff83f8 into Roblox:master May 6, 2019
@Brantone

Brantone commented May 6, 2019

Copy link
Copy Markdown
Author

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants