Fix Graphentity_Getattributes() by nafraf · Pull Request #3080 · RedisGraph/RedisGraph · GitHub
Skip to content

Fix Graphentity_Getattributes() - #3080

Open
nafraf wants to merge 47 commits into
masterfrom
fix-graphentity-getattributes
Open

nafraf wants to merge 47 commits into
masterfrom
fix-graphentity-getattributes

Conversation

@nafraf

@nafraf nafraf commented May 10, 2023 •

Copy link
Copy Markdown
Contributor

This patch is to solve: #3050, #3054, and #3056.

The function AttributeSet GraphEntity_GetAttributes(GraphEntity *e) was modified to verify that the pointer e->attributes != NULL before trying to access its value.

@nafraf nafraf changed the title Fix graphentity getattributes Fix Graphentity_Getattributes() May 10, 2023
@filipecosta90

filipecosta90 commented May 12, 2023 •

Copy link
Copy Markdown
Collaborator

@codecov

codecov Bot commented May 12, 2023 •

Copy link
Copy Markdown

Codecov Report

Patch coverage: 98.67% and project coverage change: +0.07 🎉

Comparison is base (86d6c12) 90.85% compared to head (b904f05) 90.93%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3080      +/-   ##
==========================================
+ Coverage   90.85%   90.93%   +0.07%     
==========================================
  Files         294      294              
  Lines       30269    30454     +185     
==========================================
+ Hits        27502    27694     +192     
+ Misses       2767     2760       -7     
Impacted Files Coverage Δ
src/arithmetic/string_funcs/string_funcs.c 97.26% <ø> (ø)
src/execution_plan/ops/op_node_by_id_seek.c 80.82% <81.25%> (+0.54%) ⬆️
src/ast/ast_validations.c 97.85% <99.64%> (+0.74%) ⬆️
src/execution_plan/ops/op_merge_create.c 97.94% <100.00%> (ø)
src/execution_plan/ops/shared/update_functions.c 98.25% <100.00%> (ø)
src/graph/entities/graph_entity.c 30.55% <100.00%> (-1.27%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nafraf
nafraf requested a review from swilly22 May 15, 2023 14:57
Comment thread tests/flow/test_graph_create.py Outdated
Comment thread tests/flow/test_graph_create.py
Comment thread src/graph/entities/graph_entity.c Outdated
Comment thread src/graph/graph.c Outdated
Comment thread src/graph/graph.c Outdated
Comment thread src/graph/entities/node.h Outdated
Comment thread src/graph/entities/edge.h Outdated
Comment thread src/graph/entities/graph_entity.c Outdated
Comment thread src/graph/entities/graph_entity.c Outdated
Comment thread src/execution_plan/ops/shared/create_functions.c
Comment thread src/execution_plan/ops/op_node_by_id_seek.c Outdated
Comment thread src/graph/entities/edge.h Outdated
Comment thread src/graph/entities/graph_entity.c
Comment thread tests/flow/test_comprehension_functions.py Outdated
Comment thread tests/flow/test_graph_merge.py Outdated
Comment thread tests/flow/test_query_validation.py Outdated

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Query crashes RG in GraphEntity_Properties Query crashes RG in GraphEntity_GetAttributes Query crashes in GraphEntity_Keys

4 participants