{{ message }}
Repository navigation
Conversation
nafraf
marked this pull request as ready for review
May 3, 2023 20:15
Collaborator
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #3078 +/- ##
==========================================
+ Coverage 90.85% 90.88% +0.02%
==========================================
Files 294 294
Lines 30269 30269
==========================================
+ Hits 27502 27509 +7
+ Misses 2767 2760 -7 ☔ View full report in Codecov by Sentry. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this patch is to fix #3058.
The idea is to don't score expressions with GhostEdge, because the reorder expression function was removing conditional variable length traverse operations.
Before applying the patch, the reordering of the expression removed the
Conditional Variable Length Traverseoperation and the module crashes:But for the same pattern written backwards, there was not problem: