Repository navigation
Conversation
There was a problem hiding this comment.
what happen if adding int to node?
There was a problem hiding this comment.
I am not sure if all the types listed in SI_ALL Neo4j supports to be added to a list. I'll check.
There was a problem hiding this comment.
what happen if adding int to node?
Overlooked, fixed. Thanks for noticing this.
There was a problem hiding this comment.
what about adding edge or path to array?
There was a problem hiding this comment.
As said, still checking. I have already confirmed that edge works in Neo4J. I'll update you once I finish checking.
There was a problem hiding this comment.
So paths also work. Now I really wonder whether we can use all objects here or not cuz I guess we should be able to.
There was a problem hiding this comment.
Changed to SI_ALL. Neo4J seems to be easily working with any type of object when adding to a list. However, this same function is used for addition with other types, so I had to blacklist paths, nodes and edges from being added to anything else, which also is logical and conforms with Neo4J behaviour. In the meantime though, I have found that:
true + 2causes an error in Neo4J, but in RG works (result 3).point() + 2causes an error in Neo4J, but in RG works (the result is some number).
Other types like datetime/time/duration/etc either aren't supported by RG (though defined in the enum) and/or work as in Neo4J.
There was a problem hiding this comment.
Forbade addition of a point with any other type rather than an array as well. Leaving boolean additions in place as it would be a breaking behaviour (discussed privately).
15e6786 to
b97e82e
Compare
Codecov ReportBase: 92.49% // Head: 92.47% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2726 +/- ##
==========================================
- Coverage 92.49% 92.47% -0.03%
==========================================
Files 263 263
Lines 25054 25074 +20
==========================================
+ Hits 23174 23187 +13
- Misses 1880 1887 +7 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
b97e82e to
a39c152
Compare
81326de to
bb12a4a
Compare
2303ad3 to
483c2a0
Compare
26407d8 to
27b9ab8
Compare
27b9ab8 to
b97bfe4
Compare
The aforementioned operation was not allowed to be performed earlier. This commit brings a change by allowing node objects to be added to a list. Resolves: RedisGraph#2291
A bug appeared whenever a node would be printed out with its properties and there was a prefix in the string. It was caused by not taking into account the number of bytes having already been written to the string before printing out the properties of a node. This commit changes the behaviour so that the number of bytes is taken into account and properly writes the properties map into a string.
The only allowed type of addition with the objects of aforementioned types is with T_ARRAY, what means appending or prepending to a list. This commit makes sure the objects of the aforementioned types can only be "added" this way.
Also adds a few more test cases with other types for addition with the node, edge and path objects.
b97bfe4 to
1d58054
Compare
This branch has not been deployed
2 participants
The aforementioned operation was not allowed to be performed earlier.
This commit brings a change by allowing node objects to be added to
a list.
Resolves: #2291