2.x: Javadoc space cleanup by akarnokd · Pull Request #6005 · ReactiveX/RxJava · GitHub
Skip to content

2.x: Javadoc space cleanup#6005

Merged
akarnokd merged 3 commits into
2.xfrom
JavadocSpaceCleanup
May 9, 2018
Merged

2.x: Javadoc space cleanup#6005
akarnokd merged 3 commits into
2.xfrom
JavadocSpaceCleanup

Conversation

@akarnokd

@akarnokd akarnokd commented May 9, 2018

Copy link
Copy Markdown
Member

This PR adds a gradle task to replace the excessive whitespaces generated into the Javadocs between method arguments and after method argument annotations.

This task should run before the javadoc gets packaged up for maven and before it gets pushed back to the gh-pages.

(This was created as a repo branch so that the snapshot pushback is triggered, see the comparison links below.)

Resolves: #6004

Comparison

Multiple parameters before: combineLatest

image

Multiple parameters after: combineLatest snapshot

image


Newline after parameter annotation before: as

image

Newline after parameter annotation after: as snapshot

image

@codecov

codecov Bot commented May 9, 2018

Copy link
Copy Markdown

@vanniktech vanniktech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subjects and Processors are rendering fine?

@akarnokd

akarnokd commented May 9, 2018

Copy link
Copy Markdown
Member Author

Well, ReplaySubject's multi-parameter methods are a bit misaligned too. Will update list of files.

@akarnokd

akarnokd commented May 9, 2018

Copy link
Copy Markdown
Member Author

@akarnokd akarnokd merged commit 8a28169 into 2.x May 9, 2018
@akarnokd akarnokd deleted the JavadocSpaceCleanup branch May 9, 2018 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants