{{ message }}
1.x: fix and deprecate evicting groupBy and add new overload#5917
Merged
Conversation
…add new groupBy evicting overload (ReactiveX#5868)
akarnokd
approved these changes
Mar 15, 2018
Collaborator
Author
|
Added a null check because a race with |
Collaborator
Author
|
Can we get another 1.x release with this change soonish? |
Member
|
Done. |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

See #5868
There is a problem with the existing 1.x
Observable.groupByoverload with an evicting map factory where depending on the eviction behaviour of the supplied map factory, groups may not be completed and may leak memory. The problem extends to the method signature in that the eviction action should report the evictedGroupedObservablenot the corresponding key.This PR
groups( intogroupsCopy) so that we can always successfully lookup the evicted group from thegroupsCopymap. Evictions fromgroupsare mirrored ingroupsCopyafter the lookup.groupBythat has the corrected signature and offersbufferSizeanddelayErrorparameters for a bit more flexibility and to differentiate the erased signature from the deprecated method