1.x: fix reset() shutting down everything other than the schedulers#3996
Conversation
There was a problem hiding this comment.
Any reason to not make these private?
There was a problem hiding this comment.
We try to avoid too much private modifiers; generally it adds hidden bridge methods, increasing the method count which is bad for Android. Also package level access leaves it open to same-package unit testing.
There was a problem hiding this comment.
Fair enough, though this case wouldn't generate synthetic accessors I don't think.
There was a problem hiding this comment.
Right, bridges are not in play here; it has become a second nature of me scoping as package-private.
There was a problem hiding this comment.
Not a bad approach :). LGTM then
|
Minor nit, rest of the code looks good 👍 Nice catch, sorry for the inadvertent bug and glad it was a relatively simple fix |
|
👍 |
1 similar comment
4 participants
The reset shut down all the main schedulers and the helper pools, causing the failure in #3993 .
@hzsweers, you were right with the need for the instance-shutdown method.