Add Completable.andThen(Completable), deprecate endWith() by vanniktech · Pull Request #3948 · ReactiveX/RxJava · GitHub
Skip to content

Add Completable.andThen(Completable), deprecate endWith()#3948

Merged
zsxwing merged 3 commits into
ReactiveX:1.xfrom
vanniktech:1.x_completable_and_then
May 23, 2016
Merged

Add Completable.andThen(Completable), deprecate endWith()#3948
zsxwing merged 3 commits into
ReactiveX:1.xfrom
vanniktech:1.x_completable_and_then

Conversation

@vanniktech

@vanniktech vanniktech commented May 18, 2016 •
edited by akarnokd
Loading

Copy link
Copy Markdown
Collaborator

See #3947

@akarnokd akarnokd changed the title Completable.andThen(Completable). Fixes #3947 Add Completable.andThen(Completable), deprecate endWith() May 18, 2016
@akarnokd

akarnokd commented May 18, 2016

Copy link
Copy Markdown
Member

@vanniktech

vanniktech commented May 18, 2016

Copy link
Copy Markdown
Collaborator Author

Done.

@akarnokd

akarnokd commented May 18, 2016

Copy link
Copy Markdown
Member

👍

@artem-zinnatullin

artem-zinnatullin commented May 18, 2016

Copy link
Copy Markdown
Contributor

👍 but I'd either duplicate tests or make universal test functions and test both endWith and andThen to make sure that we don't break old behavior of public api.

@DavidMGross DavidMGross mentioned this pull request May 19, 2016
Open
@vanniktech

vanniktech commented May 23, 2016

Copy link
Copy Markdown
Collaborator Author

The question is also since Completable is still @Experimental we could if this is wanted go the hard way and remove the deprecated methods and make everyone force to use the standard (new) methods since there are already quite a few deprecated / duplicated methods.

@zsxwing

zsxwing commented May 23, 2016

Copy link
Copy Markdown
Member

@zsxwing zsxwing closed this May 23, 2016
@zsxwing zsxwing reopened this May 23, 2016
@zsxwing zsxwing merged commit c296d52 into ReactiveX:1.x May 23, 2016
@zsxwing zsxwing mentioned this pull request May 23, 2016
Closed
@vanniktech vanniktech deleted the 1.x_completable_and_then branch May 24, 2016 07:49
@akarnokd akarnokd mentioned this pull request May 27, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Cleanup

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vanniktech @akarnokd @artem-zinnatullin @zsxwing