Update CHANGES.md for v1.0.16 by stealthcode · Pull Request #3517 · ReactiveX/RxJava · GitHub
Skip to content

Update CHANGES.md for v1.0.16#3517

Merged
stealthcode merged 1 commit into
1.xfrom
changesmd-v1.0.16
Nov 11, 2015
Merged

Update CHANGES.md for v1.0.16#3517
stealthcode merged 1 commit into
1.xfrom
changesmd-v1.0.16

Conversation

@stealthcode

Copy link
Copy Markdown

No description provided.

@artem-zinnatullin

Copy link
Copy Markdown
Contributor

Comment thread CHANGES.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't public API. Shouldn't need to mention.

@stealthcode

Copy link
Copy Markdown
Author

Comment thread CHANGES.md Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably read Replace all instances of Atomic*FieldUpdater with direct Atomic* instances or something.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it was internal change too :) If we want to show what this PR means to the users — we can write something like: "Replace … (fixes crashes on some Samsung devices Running on Android 5)".

@stealthcode stealthcode force-pushed the changesmd-v1.0.16 branch 2 times, most recently from 71ee3cd to 211589f Compare November 11, 2015 20:42
@akarnokd

Copy link
Copy Markdown
Member

Can we get #3493 in as well?

@stealthcode

Copy link
Copy Markdown
Author

Merged #3493 and updated.

@akarnokd

Copy link
Copy Markdown
Member

👍

@abersnaze

Copy link
Copy Markdown
Collaborator

LGTM 👍

stealthcode pushed a commit that referenced this pull request Nov 11, 2015
@stealthcode stealthcode merged commit 33340c5 into 1.x Nov 11, 2015
@stealthcode

Copy link
Copy Markdown
Author

@JakeWharton

Copy link
Copy Markdown
Contributor

@akarnokd akarnokd deleted the changesmd-v1.0.16 branch November 11, 2015 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants