Install conda activate by QuantCo-mr-T · Pull Request #1 · QuantCo-mr-T/pre-commit · GitHub
Skip to content

Install conda activate - #1

Draft
QuantCo-mr-T wants to merge 1 commit into
masterfrom
install_conda_activate
Draft

QuantCo-mr-T wants to merge 1 commit into
masterfrom
install_conda_activate

Conversation

@QuantCo-mr-T

Copy link
Copy Markdown
Owner

Uwe, magst Du mal einen Blick darauf werfen bevor ich den Pull Request offiziell einstelle?

@QuantCo-mr-T

Copy link
Copy Markdown
Owner Author

@xhochy

xhochy commented Feb 5, 2020

Copy link
Copy Markdown
Collaborator

Save conda environment that was active during conda install when using
option --hooks-activate-conda. The saved environment will be activated
before calling pre-commit hooks.

Especially on Windows, more and more actions within a conda environment
require the conda environment to be activated. Thus saving just the
python executable is not enough any more.

There is currently one downside of using the option
--hooks-activate-conda. It uses "conda run" which will only show
console output after the run is completed. We have a pull request to
conda open which introduces an option to show interactive console
output in conda run. Once this is approved, it might be ok to make this
option the default behaviour.
@QuantCo-mr-T
QuantCo-mr-T force-pushed the install_conda_activate branch from 38ea874 to dbdba3c Compare February 10, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants