[Linux] Place icons in proper dirs, according to icon size. by Fisiu · Pull Request #24 · QNapi/qnapi · GitHub
Skip to content

[Linux] Place icons in proper dirs, according to icon size.#24

Merged
krzemin merged 1 commit into
QNapi:masterfrom
Fisiu:fix-icons
Sep 9, 2015
Merged

[Linux] Place icons in proper dirs, according to icon size.#24
krzemin merged 1 commit into
QNapi:masterfrom
Fisiu:fix-icons

Conversation

@Fisiu

@Fisiu Fisiu commented Sep 5, 2015

Copy link
Copy Markdown
Contributor

Signed-off-by: Mariusz Fik mariusz@fidano.pl

@krzemin

krzemin commented Sep 6, 2015

Copy link
Copy Markdown
Member

@Fisiu

Fisiu commented Sep 6, 2015

Copy link
Copy Markdown
Contributor Author

Yes, You're right. I'll update pull rq when get back home.

@Fisiu

Fisiu commented Sep 7, 2015

Copy link
Copy Markdown
Contributor Author

It seems files{size}.extra (in qnapi.pro) doesn't work well with multiple items. Maybe just rename files res/qnapi-{size}.png → res/icons/{sizexsize}/apps/qnapi.png?

@krzemin

krzemin commented Sep 8, 2015

Copy link
Copy Markdown
Member

Did you try setting full target path of the file? I mean this instead of only providing directory in path:

icons32.files = res/qnapi-32.png
icons32.path = $${DATADIR}/icons/hicolor/32x32/apps/qnapi.png

@Fisiu

Fisiu commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

Then qnapi.png dir is created, and qnapi-{size}.png inside it.

@krzemin

krzemin commented Sep 8, 2015

Copy link
Copy Markdown
Member

Generally, it's OK to change directory structure in way you've proposed (res/icons/size/qnapi.png), but you have to be careful since current icon paths are referred to in several places (e.g. in res/resources.qrc, maybe also in some .ui files).

Signed-off-by: Mariusz Fik <mariusz@fidano.pl>
@Fisiu

Fisiu commented Sep 8, 2015

Copy link
Copy Markdown
Contributor Author

krzemin added a commit that referenced this pull request Sep 9, 2015
[Linux] Place icons in proper dirs, according to icon size.
@krzemin krzemin merged commit 29f0775 into QNapi:master Sep 9, 2015
@Fisiu Fisiu deleted the fix-icons branch September 17, 2015 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants