If you agree with this first draft, I'll work on followup PRs for log-domain, barycenters, convolutional UOT for images, and GPU compatibility.

Great ! Thanks Hicham !

Hello @hichamjanati,

Thank you very much indeed. I will have a look at your code and do a review myself but it looks great.

• I added a test for sinkhron_unbalanced2 and for the method argument as @massich suggested.
• Also one more test for a multidimensional distribution b.
• Adapted the docstring examples
  Unless you have any other requests, it's ready for merge :)

Hello, this is great.

Could you please build the doc with the makefile in the doc folder with make html and check that all your new fonction build correctly please (readthedoc dont provide build for PR).

Also don't forget to update the Readme with:

• your name in the contributors
• the new reference from frogner
• the unbalanced OT in the feature list at the top

@rflamary Thanks for the feedback
Running make html in the doc folder did not build my examples and it turns out something is really wrong with the doc ... it's also the case for many previous PRs (Fused gromov #86, #80, #73) and potentially others. The changes in those PRs do not appear on https://pot.readthedocs.io
I tracked down the last working example and it's convolutional wasserstein (#64) but I could not find any wrong changes on the doc config since then ...
any ideas ?

Hello,

The doc builds on my end and on readthedoc so I don't think there is really something wrong with it. The documentation including the latest PR is available in the 'latest' version of the doc:
https://pot.readthedocs.io/en/latest/index.html
you were looking at the stable version that corresponds the last release (on pip and conda).

Note that in order to build the doc you need sphinx-gallery . If the doc do not build, you should open an issue and describe what fails. maybe it requires some more dependencies. I am working on a big doc PR in #88 before the next release where I will do some cleanup so i can address the problem.

Sorry I put the wrong link but even in the latest version, the Fused-Gromov examples plot_fgw.py and plot_barycenter_fgw.py are not available. Their .rst versions are not in docs/source/auto_examples. I'll narrow down the issue to see what's wrong and create an issue.

OK i see,

Don't worry, there is not problem. I add the examples semi-manually to the documentation before release because the sphinx-gallery cannot run on readthedoc (you cannot compile stuff). But you have a point, it should be written somewhere, I will add a Readme in the doc folder.

What I asked wrt the documentation is that you check that the doc build and that your functions have a correct format (rst is so tricky). I will take care of adding the examples and the notebooks.

Ah okay, I see now. I have made the requested changes on the docstrings and init and added the module to source/all.rst.

Ok @hichamjanati, I will do the merge now.

Thank you for this very nice contribution, please I think the stabilized and gpu versions would be very nice follow ups to this PR.

Hello Hicham,

I'm still working on it but you can see the upcoming documentation here:
https://pot.readthedocs.io/en/doc_modules/

you can see the FGW and your examples here and they work like a charm

Hello Rémi,
Ah great, beautiful indeed :)