[WIP] implementation of low rank ot via factor relaxation paper by fegounna · Pull Request #719 · PythonOT/POT · GitHub
Skip to content

[WIP] implementation of low rank ot via factor relaxation paper#719

Open
fegounna wants to merge 10 commits into
PythonOT:masterfrom
fegounna:low-rank-via-factor-relaxation
Open

[WIP] implementation of low rank ot via factor relaxation paper#719
fegounna wants to merge 10 commits into
PythonOT:masterfrom
fegounna:low-rank-via-factor-relaxation

Conversation

@fegounna

@fegounna fegounna commented Feb 3, 2025

Copy link
Copy Markdown

Types of changes

Added implementation of the paper Low-Rank Optimal Transport through Factor Relaxation with Latent Coupling
https://arxiv.org/abs/2411.10555

How has this been tested (if it applies)

Tested it on optimal transport problems and compared it with sinkhorn solver.
Tested using numpy and torch.

PR checklist

  • I have read the CONTRIBUTING document.
  • The documentation is up-to-date with the changes I made (check build artifacts).
  • All tests passed,
  • and additional code has been covered with new tests.
  • I have added the PR and Issue fix to the RELEASES.md file.

@codecov

codecov Bot commented Feb 12, 2025

Copy link
Copy Markdown

@rflamary

Copy link
Copy Markdown
Collaborator

Hello,
Thanks for your PR. Things that need to be done before we do a full coder review:

  • Add tests for a functions with a good coverage.
  • Add examples in /examples/ folder for the documentation
  • Merge your contribution wit /ot/lowrank.py en potentially factorize code/unify API

@fegounna

Copy link
Copy Markdown
Author

Thanks you for your message.
I will do it next week.

@cedricvincentcuaz

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants