{{ message }}
reformat - move paragraph direction and image size from style attribute to "classic" attribute#39
Open
ophiry wants to merge 1 commit intoPythonFreeCourse:mainfrom
Open
reformat - move paragraph direction and image size from style attribute to "classic" attribute#39ophiry wants to merge 1 commit intoPythonFreeCourse:mainfrom
ophiry wants to merge 1 commit intoPythonFreeCourse:mainfrom
Conversation
yammesicka
requested changes
Sep 14, 2020
Member
There was a problem hiding this comment.
If it is OK on your side, I'd prefer not to move around attributes in places where it doesn't make a difference :)
Author
There was a problem hiding this comment.
I used a html parser (BeautifulSoup) to do the reformatting - there's no direct control on all the details of the generated html
| "לפעמים נרצה לצרף דברי הסבר לקוד שכתבנו.<br>\n", | ||
| "כדי להוסיף הסברים לצד הקוד נשתמש בתו סולמית, ומייד אחריה נכתוב את ההסברים שרצינו לצרף.<br>\n", | ||
| "<p dir=\"rtl\" style=\"text-align: right; direction: rtl; float: right; clear: both;\">\n", | ||
| "לפעמים נרצה לצרף דברי הסבר לקוד שכתבנו.<br/>\n", |
Member
There was a problem hiding this comment.
Let's not add closing tags to our brs, we're on HTML5 :)
| "<li><code>\"_)(*&^%\"</code></li>\n", | ||
| "<li><code>\"_)('*&^%\"</code></li>\n", | ||
| " <li><code>\"_)(\"*&^%\"</code></li>\n", | ||
| "<li><code>\"_)(*&^%\"</code></li>\n", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
re: #37