{{ message }}
Refactor MAISI tutorial, migrate GenerativeAI import#1779
Merged
Conversation
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
mingxin-zheng
previously approved these changes
Aug 12, 2024
mingxin-zheng
dismissed
their stale review
MR is still in draft state. Maybe there are some more refactors
KumoLiu
reviewed
Aug 12, 2024
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
…into refactor_maisi
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
…into refactor_maisi
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
…k to save time Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
…into refactor_maisi
for more information, see https://pre-commit.ci
Contributor
Author
|
To pass CI, it requires monai core ControlNetMaisi to remove generative dependency first. |
Contributor
It seems we can re-run it after this PR is merged: |
KumoLiu
reviewed
Aug 13, 2024
KumoLiu
reviewed
Aug 13, 2024
…iption Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
…into refactor_maisi
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
…into refactor_maisi
Signed-off-by: Can-Zhao <volcanofly@gmail.com>
for more information, see https://pre-commit.ci
KumoLiu
approved these changes
Aug 15, 2024
Contributor
|
Hi @Can-Zhao, I find there is still one place need to be updated in the maisi: https://github.com/Project-MONAI/tutorials/blob/main/generation/maisi/configs/config_maisi_diff_model.json#L3 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1772 .
Description
Refactor MAISI tutorial, migrate GenerativeAI import to monai core.
Add inference script.
Correct logging format.
VAE training notebook tested.
Diffusion training notebook tested.
ControlNet training notebook tested.
Inference notebook tested.
Checks
./figurefolder./runner.sh -t <path to .ipynb file>