Walkthrough

The GEGLU class docstring in monai/networks/blocks/activation.py was corrected to describe the operation as x1 * GELU(x2) (previously documented as x1 * Sigmoid(x2)). An Examples section demonstrating usage via Act'geglu' was added. No changes were made to the code or function signatures; the implementation already applied GELU to the gate.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

monai/networks/blocks/activation.py (1)

190-192: Consider adding a docstring to forward method.

Per coding guidelines, docstrings should describe return values. The class-level docstring documents behavior, but the forward method lacks its own docstring specifying Args/Returns. However, this is consistent with other activation classes in this file.

Optional: Add forward method docstring

     def forward(self, input: torch.Tensor):
+        """Apply GEGLU activation.
+
+        Args:
+            input: Tensor with shape (N, *, 2*D) where last dim is split for gating.
+
+        Returns:
+            Tensor with shape (N, *, D) after applying x * GELU(gate).
+        """
         x, gate = input.chunk(2, dim=-1)
         return x * nn.functional.gelu(gate)

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

• X
• Mastodon
• Reddit
• LinkedIn