{{ message }}
Removed outdated torch version checks from transform functions#8359
Merged
KumoLiu merged 7 commits intoFeb 19, 2025
Merged
Conversation
ericspod
approved these changes
Feb 19, 2025
ericspod
left a comment
ericspod
left a comment
Member
There was a problem hiding this comment.
I think this is good, if we're through the tests and blossom we can merge, thanks!
Member
Contributor
Author
|
@ericspod Thanks for the review. After a couple of attempts I managed to fix the DCO :D |
Contributor
|
/build |
KumoLiu
approved these changes
Feb 19, 2025
KumoLiu
left a comment
KumoLiu
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the quick fix, LGTM.
nkaenzig
deleted the
fix/remove-torch-version-check-from-transform-functions
branch
Contributor
Author
Member
Can-Zhao
pushed a commit
to Can-Zhao/MONAI
that referenced
this pull request
Mar 10, 2025
…ject-MONAI#8359) Fixes Project-MONAI#8348 ### Description Support for `torch` versions prior to `1.13` has been dropped, so those `1.8` version checks are not required anymore. Furthermore, as reported in the issue description, those checks led to unstable behaviour when using certain transforms in data pipelines. ### Types of changes <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Non-breaking change (fix or new feature that would not break existing functionality). - [ ] Breaking change (fix or new feature that would cause existing functionality to change). - [ ] New tests added to cover the changes. - [ ] Integration tests passed locally by running `./runtests.sh -f -u --net --coverage`. - [ ] Quick tests passed locally by running `./runtests.sh --quick --unittests --disttests`. - [ ] In-line docstrings updated. - [ ] Documentation updated, tested `make html` command in the `docs/` folder. --------- Signed-off-by: Nicolas Kaenzig <nkaenzig@gmail.com> Signed-off-by: Can-Zhao <volcanofly@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8348
Description
Support for
torchversions prior to1.13has been dropped, so those1.8version checks are not required anymore. Furthermore, as reported in the issue description, those checks led to unstable behaviour when using certain transforms in data pipelines.Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.