{{ message }}
warn or raise ValueError on duplicated key in json/yaml config#6252
Merged
Conversation
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
for more information, see https://pre-commit.ci
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Contributor
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Contributor
Author
|
I've made it a warning by default and error only when a specific env variable is set. LMK if this is ok and then I can extend it to yaml. |
Contributor
thanks, looks good to me |
Nic-Ma
approved these changes
Mar 29, 2023
Nic-Ma
left a comment
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, put some minor comments inline.
Thanks.
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
Signed-off-by: Tomasz Bartczak <kretesenator@gmail.com>
kretes
changed the title
Contributor
|
/build |
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5471 .
Description
[WIP]
Monai will now raise an error whenever there is a duplicated key in any of the config json files.
TBD:
Things to discuss:
Types of changes
./runtests.sh -f -u --net --coverage. (I couldn't run them locally due to OOM)./runtests.sh --quick --unittests --disttests.Documentation updated, testedI think that's a safeguard that doesn't require explicit documentationmake htmlcommand in thedocs/folder.