{{ message }}
5775 Fix _get_latest_bundle_version issue on Windows#5787
Merged
wyli merged 5 commits intoJan 4, 2023
Merged
Conversation
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
SachidanandAlle
approved these changes
Dec 26, 2022
Nic-Ma
approved these changes
Dec 29, 2022
Nic-Ma
left a comment
Nic-Ma
left a comment
Contributor
There was a problem hiding this comment.
Hi @yiheng-wang-nv ,
Could you please help remove this line to allow the windows tests:
https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_bundle_download.py#L61
Actually, other bundle tests cover windows, like:
https://github.com/Project-MONAI/MONAI/blob/dev/tests/test_integration_bundle_run.py#L108
Thanks.
Signed-off-by: Yiheng Wang <vennw@nvidia.com>
for more information, see https://pre-commit.ci
Contributor
Author
Contributor
|
/build |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yiheng Wang vennw@nvidia.com
Fixes #5775 .
Description
This PR fixes the issue of
_get_latest_bundle_versionon Windows (os.path.joinwill produce backslash which will create a wrong url)Thanks @SachidanandAlle for finding this issue.
Types of changes
./runtests.sh -f -u --net --coverage../runtests.sh --quick --unittests --disttests.make htmlcommand in thedocs/folder.