iframe-proxy

PtJade Ceramic (PtJade-Ceramic) · 2026-07-21T17:55:56Z

PR Summary

When a new PowerShell version is available, this PR adds WinGet integration to the update notification:

Detect WinGet availability and latest version via winget show
Upgrade with WinGet button when WinGet has a newer version than installed
Install WinGet button for Windows users without WinGet
View WinGet Progress button to follow winget-pkgs issues/PRs
Falls back to GitHub API when WinGet CLI is unavailable

WinGet only exists on Windows, so its buttons are offered there only, and the prompt is built by a pure buildUpdatePrompt() function so its buttons and message can be tested.

Resolves #5477.

PR Checklist

PR has a meaningful title
Summarized changes
PR has tests
This PR is ready to merge and is not work in progress

Testing

npm run compile, npm run lint, npm run format and npx tsc --noEmit pass.
New tests in test/features/UpdatePowerShell.test.ts cover the version parsing (from winget show output and from winget-pkgs manifest listings) and the buttons and notes the prompt produces for each WinGet state, including that WinGet options are not offered off Windows.
CI is green on Windows, macOS and Linux. Getting there needed four temporary, TODO-marked changes for pre-existing infrastructure problems (see CI Tests: PowerShellEditorServices build cannot restore .NET reference packs (NuGet feed returns 401), failing every branch since 2026-06-25 #5592): nuget.org plus package source mapping for the PowerShellEditorServices build, @vscode/test-electron 3.x for the renamed macOS binary, npmjs for the @vscode scope until the PowerShell npm mirror has that version, and fail-fast: false. They are easy to drop or move into a separate PR.

Justin Grote (JustinGrote) · 2026-07-21T20:17:21Z

Justin Grote (JustinGrote) · 2026-07-22T23:07:37Z

PtJade Ceramic (@PtJade-Ceramic)

PtJade Ceramic (PtJade-Ceramic) · 2026-07-23T10:13:41Z

PtJade Ceramic (@PtJade-Ceramic)

The code changes are clean — the macOS failure is a CI environment issue (VS Code Insiders download/corruption), unrelated to this PR. Could someone with write access please re-run the failed jobs? Thanks!

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Test-first: covers parsing of 'winget show' output and of winget-pkgs manifest listings, plus the buttons and notes the update prompt should show for each WinGet state, including that WinGet is not offered off Windows.

…werShell#5477) Detects WinGet via 'winget show --id Microsoft.PowerShell', falling back to the winget-pkgs listing when the CLI is missing. The prompt can upgrade with WinGet, install WinGet, and follow WinGet's progress, noting the version WinGet currently has. It is built by a pure buildUpdatePrompt() function, and WinGet options are only offered on Windows.

PtJade Ceramic (PtJade-Ceramic) · 2026-09-12T16:19:10Z

All checks are green now — the first green CI Tests run on this repo since 2026-06-25. Three separate infrastructure problems were in the way:

The PSES build could not restore. The nuget.config in the PowerShellEditorServices checkout lists only an Azure DevOps feed that returns 401 for packages it has not cached (details in CI Tests: PowerShellEditorServices build cannot restore .NET reference packs (NuGet feed returns 401), failing every branch since 2026-06-25 #5592), so the .NET reference packs could not be restored. Worked around here by adding nuget.org plus a packageSourceMapping for the framework reference packs.
macOS could not launch the Insiders build. VS Code 1.110 renamed the macOS main executable from Contents/MacOS/Electron to the product name (Code - Insiders for Insiders), and @vscode/test-electron 2.x hardcodes the old path, so every macOS run died with spawn ... Electron ENOENT before any test loaded. Fixed by updating it to 3.x, which resolves the executable from the bundle's Info.plist.
The npm install skipped the new package. The PowerShell npm mirror has not cached @vscode/test-electron 3.x and returns 401 for packages it has not cached; npm silently skips optional dependencies it cannot fetch, so the CI workaround serves it from npmjs until the mirror is refreshed.

The CI changes are marked with TODOs — happy to drop them or move them into a separate PR if you prefer. The matrix also had the default fail-fast, which cancelled the other platforms as soon as one failed; it is false now so every platform reports.

Nothing here changes the feature itself: the branch is rebased on main, and the change is one source file plus tests (compile, lint, format and tsc --noEmit pass locally; the new tests cover the version parsing and the prompt built for each WinGet state).

Two small asks: #5477 was closed as not planned after a misunderstanding — this is about upgrading PowerShell itself via WinGet (VS Code already manages the extension), not about shipping the extension via WinGet. And could a maintainer add the Issue-Enhancement / Area-UI labels (I don't have permission) and take a look? Thanks!

Temporary workaround: PSES's nuget.config only lists an Azure DevOps feed, which returns 401 (Unauthorized) for anonymous downloads, so CI fails while restoring the .NET reference packs before any tests run. Drop this once that is fixed upstream.

VS Code 1.110 renamed the macOS main executable from 'Contents/MacOS/Electron' to the product name ('Code - Insiders' for Insiders), so v2's hardcoded path fails with 'spawn ... Electron ENOENT' before any test runs. v3 resolves it from the bundle's Info.plist. CI needs the `@vscode` scope served by npmjs meanwhile: the PowerShell npm mirror has not cached 3.1.0 yet and returns 401 for packages it has not cached, which npm silently skips for optional dependencies. Fixes PowerShell#5592.

Copilot

🟡 Changes recommended

Unresolved WinGet detection, action, terminal, progress-link, and test-coverage issues remain.

4 open findings

🧠 Review effort: Lite

- Only offer "Upgrade with WinGet" when the installed WinGet reports a newer version; otherwise `winget update` is a guaranteed no-op while the message already says WinGet has not caught up. "View WinGet Progress" is still offered while the catalog lags. - Treat only ENOENT from `winget show` as WinGet being missing. Other failures (source lookups, network problems, and so on) keep WinGet installed with an unknown version instead of offering to install it. - Run the install action in an explicit `powershell.exe` terminal, since `Add-AppxPackage` is a PowerShell cmdlet and the user's default terminal profile may be cmd or Git Bash. - Show the terminal before sending the WinGet command so progress and errors are visible, matching how the extension reveals its own terminal.

PtJade Ceramic (PtJade-Ceramic) mentioned this pull request Jul 21, 2026

Allow upgrading with WinGet #5477

Closed

2 tasks done

github-actions Bot mentioned this pull request Jul 21, 2026

[aw] No-Op Runs #5530

Open

Justin Grote (JustinGrote) marked this pull request as draft July 21, 2026 20:17

PtJade Ceramic (PtJade-Ceramic) marked this pull request as ready for review July 22, 2026 08:09

PtJade Ceramic (PtJade-Ceramic) marked this pull request as draft July 22, 2026 08:17

PtJade Ceramic (PtJade-Ceramic) changed the title ~~feat: add WinGet upgrade option to PowerShell update notification (#5477)~~ WIP: feat: add WinGet upgrade option to PowerShell update notification (#5477) Jul 22, 2026

PtJade Ceramic (PtJade-Ceramic) changed the title ~~WIP: feat: add WinGet upgrade option to PowerShell update notification (#5477)~~ feat: add WinGet upgrade option to PowerShell update notification (#5477) Jul 22, 2026

PtJade Ceramic (PtJade-Ceramic) marked this pull request as ready for review July 22, 2026 08:26

Justin Grote (JustinGrote) marked this pull request as draft July 22, 2026 23:07

PtJade Ceramic (PtJade-Ceramic) marked this pull request as ready for review July 23, 2026 10:31

PtJade Ceramic (PtJade-Ceramic) requested a review from a team as a code owner July 23, 2026 10:31

PtJade Ceramic (PtJade-Ceramic) force-pushed the feat/winget-upgrade branch from ff9fa3e to 3575846 Compare September 12, 2026 11:55

Copilot AI balanced review requested due to automatic review settings September 12, 2026 11:55

Copilot AI reviewed Sep 12, 2026

PtJade Ceramic (PtJade-Ceramic) added 2 commits September 12, 2026 22:48

test: define WinGet parsing and update prompt behavior

f0b0133

Test-first: covers parsing of 'winget show' output and of winget-pkgs manifest listings, plus the buttons and notes the update prompt should show for each WinGet state, including that WinGet is not offered off Windows.

PtJade Ceramic (PtJade-Ceramic) force-pushed the feat/winget-upgrade branch 2 times, most recently from 103d4f7 to a4b0e45 Compare September 12, 2026 16:09

PtJade Ceramic (PtJade-Ceramic) mentioned this pull request Sep 12, 2026

CI Tests: PowerShellEditorServices build cannot restore .NET reference packs (NuGet feed returns 401), failing every branch since 2026-06-25 #5592

Open

PtJade Ceramic (PtJade-Ceramic) force-pushed the feat/winget-upgrade branch 2 times, most recently from 5d1b946 to 12e0256 Compare September 12, 2026 16:47

PtJade Ceramic (PtJade-Ceramic) force-pushed the feat/winget-upgrade branch 4 times, most recently from 0a3ccc1 to fd56c92 Compare September 12, 2026 18:40

PtJade Ceramic (PtJade-Ceramic) force-pushed the feat/winget-upgrade branch from fd56c92 to b17a977 Compare September 13, 2026 05:21

PtJade Ceramic (PtJade-Ceramic) requested a lite review from Copilot October 14, 2026 21:58

Copilot started reviewing on behalf of PtJade Ceramic (PtJade-Ceramic) October 14, 2026 21:59

View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Comment thread src/features/UpdatePowerShell.ts Outdated

Comment thread src/features/UpdatePowerShell.ts Outdated

Comment thread src/features/UpdatePowerShell.ts Outdated

Comment thread src/features/UpdatePowerShell.ts Outdated

PtJade Ceramic (PtJade-Ceramic) force-pushed the feat/winget-upgrade branch from f9ea9a3 to 096ead7 Compare October 15, 2026 06:35

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

feat: add WinGet upgrade option to PowerShell update notification (#5477) - #5558

feat: add WinGet upgrade option to PowerShell update notification (#5477)#5558
PtJade Ceramic (PtJade-Ceramic) wants to merge 5 commits into
PowerShell:mainfrom
PtJade-Ceramic:feat/winget-upgrade

PtJade Ceramic (PtJade-Ceramic) commented Jul 21, 2026 •

edited

Loading

Uh oh!

Justin Grote (JustinGrote) commented Jul 21, 2026

Uh oh!

Justin Grote (JustinGrote) commented Jul 22, 2026

Uh oh!

PtJade Ceramic (PtJade-Ceramic) commented Jul 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

PtJade Ceramic (PtJade-Ceramic) commented Sep 12, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

PtJade Ceramic (PtJade-Ceramic) commented Jul 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Checklist

Testing

Uh oh!

Justin Grote (JustinGrote) commented Jul 21, 2026

Uh oh!

Justin Grote (JustinGrote) commented Jul 22, 2026

Uh oh!

PtJade Ceramic (PtJade-Ceramic) commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

PtJade Ceramic (PtJade-Ceramic) commented Sep 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

PtJade Ceramic (PtJade-Ceramic) commented Jul 21, 2026 •

edited

Loading

PtJade Ceramic (PtJade-Ceramic) commented Jul 23, 2026 •

edited

Loading

PtJade Ceramic (PtJade-Ceramic) commented Sep 12, 2026 •

edited

Loading