Update .NET, PSReadLine, and Nuget packages by andyleejordan · Pull Request #2262 · PowerShell/PowerShellEditorServices · GitHub
Skip to content

Update .NET, PSReadLine, and Nuget packages#2262

Merged
andyleejordan merged 2 commits intomainfrom
updates-packages
Nov 25, 2025
Merged

Update .NET, PSReadLine, and Nuget packages#2262
andyleejordan merged 2 commits intomainfrom
updates-packages

Conversation

@andyleejordan
Copy link
Copy Markdown
Member

@andyleejordan andyleejordan commented Nov 25, 2025

Seems like a test is hung locally, seeing if it repros in CI.

@andyleejordan andyleejordan marked this pull request as ready for review November 25, 2025 22:33
@andyleejordan andyleejordan requested a review from a team as a code owner November 25, 2025 22:33
Copilot AI review requested due to automatic review settings November 25, 2025 22:33
@andyleejordan andyleejordan enabled auto-merge (rebase) November 25, 2025 22:33
SeeminglyScience
SeeminglyScience approved these changes Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@SeeminglyScience SeeminglyScience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andyleejordan andyleejordan merged commit 7b40f14 into main Nov 25, 2025
13 checks passed
@andyleejordan andyleejordan deleted the updates-packages branch November 25, 2025 22:34
Copilot AI reviewed Nov 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates .NET SDK, PSReadLine module, and various NuGet package dependencies. The changes also include test attribute corrections and modifications to the module restore logic to improve incremental builds.

  • Updates .NET SDK from 8.0.405 to 8.0.416
  • Upgrades several NuGet packages including Microsoft.Extensions., Roslynator., and Newtonsoft.Json
  • Updates PSReadLine from 2.4.4-beta4 to 2.4.5 and refactors module restore logic
  • Corrects test attributes: removes empty parentheses from [SkippableFact()] and changes tests without skip conditions from [SkippableFact] to [Fact]

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
global.json Updates .NET SDK version to 8.0.416
Directory.Packages.props Updates multiple NuGet packages including Microsoft.Extensions., Microsoft.NET.Test.Sdk, Microsoft.PowerShell.SDK, Newtonsoft.Json, Roslynator., and System.ValueTuple
PowerShellEditorServices.build.ps1 Updates PSReadLine to 2.4.5, refactors RestorePsesModules task to check each module individually and improve incremental restore behavior
test/PowerShellEditorServices.Test/Language/SymbolsServiceTests.cs Removes unnecessary empty parentheses from [SkippableFact()] attribute
test/PowerShellEditorServices.Test/Language/CompletionHandlerTests.cs Changes [SkippableFact] to [Fact] for test without skip conditions
test/PowerShellEditorServices.Test.E2E/LanguageServerProtocolMessageTests.cs Changes [SkippableFact] to [Fact] for test without skip conditions
test/PowerShellEditorServices.Test.E2E/DebugAdapterProtocolMessageTests.cs Updates Pester test skip condition to always skip with clearer message

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread PowerShellEditorServices.build.ps1
}
if (-not (Test-Path "module/PSReadLine")) {
Write-Build DarkMagenta "Restoring PSReadLine module"
Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Repository $PSRepository -TrustRepository -Verbose
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PSReadLine version is being updated from "2.4.4-beta4" (with -Prerelease flag) to "2.4.5" (without -Prerelease flag). Verify that version 2.4.5 is a stable release and not a prerelease version. If 2.4.5 is still a prerelease, the -Prerelease flag should be retained on line 129.

Suggested change
Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Repository $PSRepository -TrustRepository -Verbose
Save-PSResource -Path module -Name PSReadLine -Version "2.4.5" -Prerelease -Repository $PSRepository -TrustRepository -Verbose

Copilot uses AI. Check for mistakes.
Comment thread Directory.Packages.props
<PackageVersion Include="Microsoft.Extensions.Logging" Version="10.0.0" />
<PackageVersion Include="Microsoft.Extensions.Logging.Debug" Version="10.0.0" />
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.1" />
<PackageVersion Include="Microsoft.PowerShell.5.ReferenceAssemblies" Version="1.1.0" />
Copy link

Copilot AI Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Downgrading Microsoft.PowerShell.SDK from 7.5.2 to 7.4.13 appears to be a version rollback rather than an update. Please verify this is intentional. If compatibility issues exist with 7.5.2, consider documenting the reason for the downgrade.

Suggested change

Copilot uses AI. Check for mistakes.
@andyleejordan andyleejordan added Issue-Enhancement A feature request (enhancement). Area-Build & Release labels Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@SeeminglyScience SeeminglyScience SeeminglyScience approved these changes

Assignees

No one assigned

Labels

Area-Build & Release Issue-Enhancement A feature request (enhancement).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andyleejordan @SeeminglyScience