Add WindowActionOnEnd for Start-DebugAttachSession by jborean93 · Pull Request #2252 · PowerShell/PowerShellEditorServices · GitHub
Skip to content

Add WindowActionOnEnd for Start-DebugAttachSession#2252

Merged
andyleejordan merged 1 commit intoPowerShell:mainfrom
jborean93:on-end-window-action
Sep 3, 2025
Merged

Add WindowActionOnEnd for Start-DebugAttachSession#2252
andyleejordan merged 1 commit intoPowerShell:mainfrom
jborean93:on-end-window-action

Conversation

@jborean93
Copy link
Copy Markdown
Contributor

PR Summary

Adds the parameter -WindowActionOnEnd that corresponds to the new VSCode attach configuration option
temporaryConsoleWindowActionOnDebugEnd.

PR Context

PR that added the VSCode debug option PowerShell/vscode-powershell#5255.

Adds the parameter `-WindowActionOnEnd` that corresponds to the new
VSCode attach configuration option
`temporaryConsoleWindowActionOnDebugEnd`.
Copilot AI review requested due to automatic review settings August 26, 2025 20:49
@jborean93 jborean93 requested a review from a team as a code owner August 26, 2025 20:49
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds the -WindowActionOnEnd parameter to the Start-DebugAttachSession PowerShell command to control the behavior of temporary debug consoles after debugging sessions end. This parameter corresponds to the new VSCode attach configuration option temporaryConsoleWindowActionOnDebugEnd.

  • Adds new -WindowActionOnEnd parameter with three possible values: Close, Hide, and Keep
  • Updates command syntax documentation to include the new parameter
  • Implements the parameter mapping to the debug configuration

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
module/docs/Start-DebugAttachSession.md Updates documentation to include new -WindowActionOnEnd parameter in syntax and parameter descriptions
module/PowerShellEditorServices/Commands/Public/Start-DebugAttachSession.ps1 Adds parameter definition and implementation logic for -WindowActionOnEnd

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI Aug 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documentation states that Keep is the default value, but the parameter definition shows Default value: None. This inconsistency should be corrected - either update the parameter definition to show Keep as the default or clarify that None means the system default behavior.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Member

@andyleejordan andyleejordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andyleejordan andyleejordan merged commit bdd85ec into PowerShell:main Sep 3, 2025
6 checks passed
@jborean93 jborean93 deleted the on-end-window-action branch September 3, 2025 18:11
@andyleejordan andyleejordan added the Issue-Enhancement A feature request (enhancement). label Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Enhancement A feature request (enhancement).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants