Multiple test fixes and improved logging for fragile tests by adityapatwardhan · Pull Request #9569 · PowerShell/PowerShell · GitHub
Skip to content

Multiple test fixes and improved logging for fragile tests#9569

Merged
adityapatwardhan merged 17 commits intoPowerShell:masterfrom
adityapatwardhan:RAFixes
May 10, 2019
Merged

Multiple test fixes and improved logging for fragile tests#9569
adityapatwardhan merged 17 commits intoPowerShell:masterfrom
adityapatwardhan:RAFixes

Conversation

@adityapatwardhan
Copy link
Copy Markdown
Member

@adityapatwardhan adityapatwardhan commented May 8, 2019 •
edited
Loading

PR Summary

  • Read-Host - set the expect file to be executable
  • DotNetAPI - lookup a type instead of calling an API that does not work on all platforms
  • ExecutionPolicy - Fix test and improve logging for the test
  • GetCommand - Fix test
  • Markdown cmdlet - Fix tests on platforms that do not support VT100.
  • BasicEngine - Add more logging for fragile test. This fails intermittently.
  • TaskBasedAsyncPowerShellAPI - Add a sleep for waiting for the pipeline to start. Also added more logging.
  • HelpSystem.Online - Fix the expected environment variable as AzDevOps makes are variable all caps.

PR Context

Fix multiple test failures found while running release automation tests on multiple platforms.

PR Checklist

@adityapatwardhan adityapatwardhan changed the title Multiple test fixes and improved logging for fragile tests [WIP] Multiple test fixes and improved logging for fragile tests May 8, 2019
JamesWTruher
JamesWTruher reviewed May 8, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@JamesWTruher JamesWTruher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just nits and a typo. Should probably fix the typo

Comment thread test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/MarkdownCmdlets.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/MarkdownCmdlets.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/MarkdownCmdlets.Tests.ps1 Outdated
@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented May 9, 2019

@adityapatwardhan adityapatwardhan changed the title [WIP] Multiple test fixes and improved logging for fragile tests Multiple test fixes and improved logging for fragile tests May 9, 2019
@adityapatwardhan
Copy link
Copy Markdown
Member Author

adityapatwardhan commented May 9, 2019

@JamesWTruher I have addressed your comments. Please have another look.

TravisEz13
TravisEz13 reviewed May 9, 2019
View reviewed changes
Comment thread test/powershell/Host/ConsoleHost.Tests.ps1 Outdated
TravisEz13
TravisEz13 reviewed May 9, 2019
View reviewed changes
Comment thread test/powershell/Modules/Microsoft.PowerShell.Security/ExecutionPolicy.Tests.ps1 Outdated
@adityapatwardhan adityapatwardhan merged commit ade85b4 into PowerShell:master May 10, 2019
@adityapatwardhan adityapatwardhan deleted the RAFixes branch May 10, 2019 17:56
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented May 15, 2019

@adityapatwardhan adityapatwardhan added this to the 6.2.1 milestone May 15, 2019
@TravisEz13 TravisEz13 added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

+1 more reviewer

@JamesWTruher JamesWTruher JamesWTruher left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Milestone

6.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@adityapatwardhan @PoshChan @TravisEz13 @JamesWTruher