Cleanup: sort usings by iSazonov · Pull Request #9283 · PowerShell/PowerShell · GitHub
Skip to content

Cleanup: sort usings#9283

Merged
iSazonov merged 5 commits intoPowerShell:masterfrom
iSazonov:cleanup-sort-usings
Apr 9, 2019
Merged

Cleanup: sort usings#9283
iSazonov merged 5 commits intoPowerShell:masterfrom
iSazonov:cleanup-sort-usings

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Apr 3, 2019

PR Summary

Fix CodeFactor issues by sorting usings in Microsoft.PowerShell.Commands.Utility.

The sorting was done using a VS Code string sort plugin.

PR Context

PR Checklist

@iSazonov iSazonov added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Apr 3, 2019
@iSazonov iSazonov added this to the 6.3.0-preview.1 milestone Apr 3, 2019
@iSazonov iSazonov self-assigned this Apr 3, 2019
@iSazonov iSazonov force-pushed the cleanup-sort-usings branch from be0fab9 to 32c5afc Compare April 3, 2019 10:35
@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Apr 3, 2019

@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Apr 3, 2019

@PoshChan Please rebuild windows

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Apr 3, 2019

@iSazonov, successfully started rebuild of PowerShell-CI-Windows

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a rule that System namespaces go first?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@iSazonov iSazonov merged commit aba3bd5 into PowerShell:master Apr 9, 2019
@iSazonov iSazonov deleted the cleanup-sort-usings branch April 9, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants