Conversation
|
Yes, but CodeFactor still reports "is" and "_is" https://www.codefactor.io/repository/github/powershell/powershell/issues?category=Style&groupId=15 Update: from previous PR https://www.codefactor.io/repository/github/powershell/powershell/pull/8500 - there is CodeFactor reports that "is" and "_is" too. |
|
some tools read from master and don't use the configuration files from the PR. I'm just guessing. |
|
It's actually difficult to read the updated config from a PR as the json you get back is just the diff of the file and not the complete file. This is why for @PoshChan I always look in master rather than trying to generate the resulting config file from master + diff. |
|
@TravisEz13 There is really a problem. As @SteveL-MSFT mentioned above allowCommonHungarianPrefixes enabled "is" by default - I found this in source code too. But CodeFactor continues to report "is". We can see this in previous @daxian-dbw PR #8500 - it seems CodeFactor read config from commit - and then in master too. |
This reverts commit 494e977.

PR Summary
Add very popular "is" and "_is" prefixes.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.