Change label in doc issue template by iSazonov · Pull Request #8895 · PowerShell/PowerShell · GitHub
Skip to content

Change label in doc issue template#8895

Merged
TravisEz13 merged 1 commit intoPowerShell:masterfrom
iSazonov:issue-template-doc
Feb 26, 2019
Merged

Change label in doc issue template#8895
TravisEz13 merged 1 commit intoPowerShell:masterfrom
iSazonov:issue-template-doc

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Feb 14, 2019 •
edited by TravisEz13
Loading

PR Summary

CL-* is used only for ChangeLog automation.

PR Context

PR Checklist

@iSazonov iSazonov requested a review from SteveL-MSFT February 14, 2019 14:51
RDIL
RDIL reviewed Feb 14, 2019
View reviewed changes
Comment thread .github/ISSUE_TEMPLATE/Documentation_Issue.md Outdated
Copy link
Copy Markdown
Contributor

@RDIL RDIL Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, but I think this might need to be an array or just 1 label.

Copy link
Copy Markdown
Collaborator

@vexx32 vexx32 Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I remember the syntax right this needs to look more like this:

Suggested change
labels: Issue-Question,Area-Documentation
labels: [Issue-Question, Area-Documentation]

Copy link
Copy Markdown
Collaborator Author

@iSazonov iSazonov Feb 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working sample https://raw.githubusercontent.com/lee-dohm/test-repo/master/.github/ISSUE_TEMPLATE/Bug_report.md

@iSazonov iSazonov changed the title Change label in doc issue teplate Change label in doc issue template Feb 14, 2019
@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Feb 26, 2019

@TravisEz13 Can we merge the template update?

@TravisEz13 TravisEz13 added CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log and removed CL-Untagged labels Feb 26, 2019
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Feb 26, 2019

restarted the windows CI. Ping me if it passes.

@RDIL
Copy link
Copy Markdown
Contributor

RDIL commented Feb 26, 2019

It failed

@vexx32
Copy link
Copy Markdown
Collaborator

vexx32 commented Feb 26, 2019

Weren't there a couple PRs to remove appveyor refs from the build? Error is:

Invoke-AppveyorInstall : The term 'Invoke-AppveyorInstall' is not recognized as the name of a cmdlet, function, script 
file, or operable program. Check the spelling of the name, or if a path was included, verify that the path is correct 
and try again.

Maybe try fast forwarding your branch to latest master?

@RDIL
Copy link
Copy Markdown
Contributor

RDIL commented Feb 26, 2019

Yeah, that would be the set of PRs I opened. Rebasing (should) fix it

@iSazonov
Copy link
Copy Markdown
Collaborator Author

iSazonov commented Feb 26, 2019

@TravisEz13 TravisEz13 merged commit 31699be into PowerShell:master Feb 26, 2019
@iSazonov iSazonov deleted the issue-template-doc branch February 27, 2019 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@joeyaiello joeyaiello Awaiting requested review from joeyaiello

@SteveL-MSFT SteveL-MSFT Awaiting requested review from SteveL-MSFT

+2 more reviewers

@vexx32 vexx32 vexx32 left review comments

@RDIL RDIL RDIL left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@TravisEz13 TravisEz13

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iSazonov @TravisEz13 @RDIL @vexx32