Fix broken python method#8821
Conversation
RDIL
requested review from
HemantMahawar,
SteveL-MSFT and
joeyaiello
as code owners
|
@iSazonov what do you mean? I’m just fixing broken code in this PR. |
|
I guess that the code worked on old Python version. |
|
The code clearly defines that the script should use a python 3.x.x version, but the this keyword hasn’t been a thing since the 2.5 series. I think it is time to update! |
rjmholt
left a comment
rjmholt
left a comment
There was a problem hiding this comment.
Worth noting that neither this nor self are keywords in Python; instance methods in Python pass the instance reference explicitly through the first parameter, and you can call that parameter whatever you like (you don't even need to be consistent):
class MyObject:
def __init__(banana):
banana.field = 10
def get_field(truck):
return truck.field
if __name__ == '__main__':
print(MyObject().get_field()) # prints '10'So this Python script would have run correctly using this.
However, self is the near-universal convention, and worth us aligning to that, especially in our examples. Thanks @RDIL!
iSazonov
added
the
CL-Docs
|
@SteveL-MSFT Make sense to move this to Docs repo? |
5 participants
PR Summary
thisdoesn’t work in python, the keyword isself.PR Context
It needs to be fixed.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.[feature]to your commit messages if the change is significant or affects feature tests