Fix cleanup config files by iSazonov · Pull Request #8761 · PowerShell/PowerShell · GitHub
Skip to content

Fix cleanup config files#8761

Merged
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
iSazonov:xunit-deletefile
Jan 30, 2019
Merged

Fix cleanup config files#8761
adityapatwardhan merged 2 commits intoPowerShell:masterfrom
iSazonov:xunit-deletefile

Conversation

@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov commented Jan 28, 2019

PR Summary

Related #8715.

Add attempts to delete configuration files.

PR Context

There sometimes is a race condition in xUnit tests - powershell.config.json file is blocked in one process and another process tries to remove the file.

PR Checklist

Comment thread test/xUnit/csharp/test_PSConfiguration.cs Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxPause is better than count

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@iSazonov
Copy link
Copy Markdown
Collaborator Author

@adityapatwardhan adityapatwardhan merged commit 5097e2a into PowerShell:master Jan 30, 2019
@adityapatwardhan adityapatwardhan added the CL-Test Indicates that a PR should be marked as a test change in the Change Log label Jan 30, 2019
@iSazonov iSazonov deleted the xunit-deletefile branch January 30, 2019 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-Test Indicates that a PR should be marked as a test change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants