Fix expect 100-continue Issue with Web Cmdlets by markekraus · Pull Request #8679 · PowerShell/PowerShell · GitHub
Skip to content

Fix expect 100-continue Issue with Web Cmdlets#8679

Merged
iSazonov merged 3 commits intoPowerShell:masterfrom
markekraus:feature/7199-Fix-Expect-100-Issue
Jan 19, 2019
Merged

Fix expect 100-continue Issue with Web Cmdlets#8679
iSazonov merged 3 commits intoPowerShell:masterfrom
markekraus:feature/7199-Fix-Expect-100-Issue

Conversation

@markekraus
Copy link
Copy Markdown
Contributor

@markekraus markekraus commented Jan 18, 2019

PR Summary

Fixes #7199

Web Cmdlets will no longer forcibly remove Expect: 100-continue from web requests.
This was a legacy setting that needed to be there because of platform differences that have since been resolved in CoreFX.

PR Context

#7199

PR Checklist

Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the change can break some scripts we could mark this with Breaking-Change label.

Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated
Comment thread test/powershell/Modules/Microsoft.PowerShell.Utility/WebCmdlets.Tests.ps1 Outdated
@markekraus
Copy link
Copy Markdown
Contributor Author

@iSazonov
Copy link
Copy Markdown
Collaborator

@markekraus Thanks! If we don't break any scripts the breaking-change label is not needed.

@iSazonov iSazonov merged commit 67004aa into PowerShell:master Jan 19, 2019
@iSazonov
Copy link
Copy Markdown
Collaborator

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Invoke-WebRequest][PSVersion 6.0.2] Unable to set "expect" (100-continue) request-header field in multipart/form-data

4 participants