-Verbose should not override $ErrorActionPreference by SteveL-MSFT · Pull Request #5113 · PowerShell/PowerShell · GitHub
Skip to content

-Verbose should not override $ErrorActionPreference#5113

Merged
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
SteveL-MSFT:verbose-downgrade
Oct 26, 2017
Merged

-Verbose should not override $ErrorActionPreference#5113
adityapatwardhan merged 3 commits intoPowerShell:masterfrom
SteveL-MSFT:verbose-downgrade

Conversation

@SteveL-MSFT
Copy link
Copy Markdown
Member

Fix #2247

@SteveL-MSFT SteveL-MSFT added the Breaking-Change breaking change that may affect users label Oct 14, 2017
Copy link
Copy Markdown

@anmenaga anmenaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is only for Verbose;
however, original issue says that it was approved for both: Verbose and Debug : "Committee agrees that we should fix this so that -ErrorAction works correctly and not overridden by -Debug or -Verbose".
Should this change be done for Debug as well?

@SteveL-MSFT
Copy link
Copy Markdown
Member Author

@SteveL-MSFT
Copy link
Copy Markdown
Member Author

@anmenaga can you review again?

Path = "$testdrive\test.txt";
Confirm = $false
}
New-Item @params
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

> $null

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will add

@SteveL-MSFT
Copy link
Copy Markdown
Member Author

@adityapatwardhan can you review again?

@adityapatwardhan adityapatwardhan merged commit b1af9ea into PowerShell:master Oct 26, 2017
@SteveL-MSFT SteveL-MSFT deleted the verbose-downgrade branch October 26, 2017 22:35
@mintsoft
Copy link
Copy Markdown

Is this likely to make it into the final for Powershell 6?

@markekraus
Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking-Change breaking change that may affect users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants