{{ message }}
Closed
Conversation
daxian-dbw
reviewed
Aug 3, 2017
Member
There was a problem hiding this comment.
This one can be removed, it's actually the same as the ValidateSetAttribute enhancement work we mentioned above.
daxian-dbw
reviewed
Aug 3, 2017
| ### Build/test and code cleanup | ||
|
|
||
| * Add build check for MFC for Visual C++ during Windows builds. | ||
| This fixes a long-standing (and very frustrating!) issue with missing build dependencies! (#4185) (Thanks to @KirkMunro!) |
Member
There was a problem hiding this comment.
We should add one more item here:
#4335 - Separate Windows PSRP binary build out of Start-PSBuild
Starting from beta.5, Start-PSBuild doesn't build PSRP binary on windows. Instead, the PSRP binary is consumed from a NuGet package.
SteveL-MSFT
requested changes
Aug 3, 2017
| * Fix output of `Length` for `FileInfo` when using `Format-List`. (#4437) | ||
| * Fix an issue in implicit remoting where restricted sessions couldn't use `Get-FormatData –PowerShellVersion`. (#4222) | ||
| * Fix an issue where `Register-PSSessionConfiguration` fails if `SessionConfig` folder doesn't exist. (#4271) | ||
| * Remove the `*-Counter` cmdlets in `Microsoft.PowerShell.Diagnostics` due to the use of unsupported APIs until a better solution is found. (#4303) |
Member
There was a problem hiding this comment.
I thought we were going to highlight breaking changes? Same for LocalAccounts
| so we are removing a large amount of code that's built only for FullCLR. | ||
| To read more about this, check out [this blog post](https://blogs.msdn.microsoft.com/powershell/2017/07/14/powershell-6-0-roadmap-coreclr-backwards-compatibility-and-more/). | ||
|
|
||
| * Cleanup `#if CORE` in `ManagedEntrance.cs` (#4373) (Thanks to @iSazonov!) |
Member
There was a problem hiding this comment.
We should combine these per contributor call out rather than list them all out. It's not useful to end users.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.