{{ message }}
Add 'CSharpVersion7' member into public 'Language' enum#3933
Merged
mirichmo merged 1 commit intoPowerShell:masterfrom Jun 20, 2017
Merged
Add 'CSharpVersion7' member into public 'Language' enum#3933mirichmo merged 1 commit intoPowerShell:masterfrom
mirichmo merged 1 commit intoPowerShell:masterfrom
Conversation
Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp' already contains 'CSharp7' member. After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7' member into public 'Microsoft.PowerShell.Commands.Language' enum too. This will allow 'Add-Type -Language CSharpVersion7'
Contributor
There was a problem hiding this comment.
Should we add a test case for 'Add-Type -Language CSharpVersion7'?
Contributor
There was a problem hiding this comment.
Also, should there be two commits (one for the product change and one for the test)?
Collaborator
Author
There was a problem hiding this comment.
We checked it manually in the original Issue.
I didn't touch the functionality of this cmdlet. Besides, we don't even have tests for it right now. So I believe this is a separate huge job.
It seems @daxian-dbw is working on Add-Type. It would be good to agree on the distribution of work on tests.
I can say nothing about separate commits. 😕
Member
There was a problem hiding this comment.
Two commits (one for code changes and one for tests) is not a strict requirement.
Collaborator
Author
mirichmo
approved these changes
Jun 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #3853
Public enum 'LanguageVersion' from 'Microsoft.CodeAnalysis.CSharp'
already contains 'CSharp7' member.
After moving PowerShell to .Net Core 2.0 we should add 'CSharpVersion7'
member into public 'Microsoft.PowerShell.Commands.Language' enum too.
This will allow 'Add-Type -Language CSharpVersion7'