{{ message }}
Repository navigation
[release/v7.6.6] Prepare for onboarding PowerShell to the Native2Native localization pipeline - #27916
Merged
Patrick Meinecke (SeeminglyScience) merged 1 commit intoSep 1, 2026
Conversation
…ipeline (PowerShell#27667) 1. Create the `LocProject.json` file for PowerShell localization. 2. Remove the unused `.resx` resource files and source files. 3. Update the `ResourceValidation` tests.
Patrick Meinecke (SeeminglyScience)
requested a review
from Justin Chung (jshigetomi)
as a code owner
September 1, 2026 00:41
Patrick Meinecke (SeeminglyScience)
added
the
CL-BuildPackaging
Patrick Meinecke (SeeminglyScience)
requested review from
a team,
Travis Plunk (TravisEz13) and
Dongbo Wang (daxian-dbw)
as code owners
September 1, 2026 00:41
3 of 9 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Backports #27667 to release/v7.6.6 to prepare PowerShell for the Native2Native localization pipeline by adding localization project configuration and removing unused/dead resource + source files, while updating ResourceValidation tests to align with the cleaned-up resource set.
Changes:
- Add
Localize/LocProject.jsonto define the Native2Native localization inputs/outputs across key assemblies. - Remove unused
.resxand legacy/unshipped.cssource files and simplify related.csprojexclusions. - Update ResourceValidation tests to stop excluding resources that are no longer present, and make
Test-ResourceStrings’sExcludeListoptional.
Reviewed changes
Copilot reviewed 74 out of 100 changed files in this pull request and generated no comments.
Show a summary per file
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Aditya Patwardhan (adityapatwardhan)
approved these changes
Sep 1, 2026
Patrick Meinecke (SeeminglyScience)
merged commit Sep 1, 2026
581679c
into
PowerShell:release/v7.6.6
39 checks passed
3 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27667 to release/v7.6.6
Triggered by Patrick Meinecke (@SeeminglyScience) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Sets up the Native2Native localization pipeline (LocProject.json) and removes unused resource/source files, required for onboarding PowerShell 7.6 to localization.
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Verified the cherry-picked commit builds correctly with all unused files removed and csproj references cleaned up. Original PR updated ResourceValidation tests accordingly, which were carried over in this backport unchanged.
Risk
REQUIRED: Check exactly one box.
Removes unused/dead code and resource files and adds localization pipeline configuration (LocProject.json). No behavioral changes to shipped cmdlets. Validated in master; risk is limited to build/packaging correctness rather than runtime behavior.
Merge Conflicts
Files deleted by the original PR (
ControlPanelItemCommand.cs,Eventlog.cs,WebServiceProxy.cs,cmdlets-over-objects.xmlSerializer.autogen.cs) conflicted because the release branch had unrelated trivial diagnostic/whitespace fixes applied since divergence. Accepted the deletions per the PR's intent (removing unused files).Microsoft.PowerShell.Commands.Utility.csprojandSystem.Management.Automation.csprojhad conflicts where the release branch pins different package versions (Microsoft.CodeAnalysis.CSharp5.0.0 vs 5.6.0,System.Drawing.Common10.0.5 vs 11.0.0-preview) and has an extraEmbeddedResource Includeforcmdlets-over-objects.xsdfrom a prior backport; resolved by keeping the release branch's package versions and existing resource include, while applying the PR's removal ofCompile Remove/EmbeddedResource Removeentries for the now-deleted files.